Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate event loop fixture overrides #632

Merged

Conversation

seifertm
Copy link
Contributor

@seifertm seifertm commented Oct 9, 2023

Emit a DeprecationWarning when a test run by asyncio depends on a fixture named event_loop and that fixture definition is not the same as the one provided by pytest-asycnio.

Closes #631

Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
@seifertm seifertm force-pushed the feat/deprecate-event-loop-fixture-overrides branch from 685560a to 2acf559 Compare October 13, 2023 10:40
@seifertm seifertm marked this pull request as ready for review October 13, 2023 10:40
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.31%. Comparing base (617b905) to head (2acf559).
Report is 345 commits behind head on main.

Files with missing lines Patch % Lines
pytest_asyncio/plugin.py 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #632      +/-   ##
==========================================
- Coverage   93.49%   93.31%   -0.18%     
==========================================
  Files           2        2              
  Lines         338      344       +6     
  Branches       70       71       +1     
==========================================
+ Hits          316      321       +5     
  Misses         12       12              
- Partials       10       11       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seifertm seifertm added this pull request to the merge queue Oct 16, 2023
Merged via the queue into pytest-dev:main with commit df5362a Oct 16, 2023
8 checks passed
@seifertm seifertm deleted the feat/deprecate-event-loop-fixture-overrides branch October 16, 2023 14:47
@seifertm seifertm restored the feat/deprecate-event-loop-fixture-overrides branch October 21, 2023 10:29
@seifertm seifertm deleted the feat/deprecate-event-loop-fixture-overrides branch October 23, 2023 06:13
@seifertm seifertm restored the feat/deprecate-event-loop-fixture-overrides branch October 23, 2023 08:17
@seifertm seifertm deleted the feat/deprecate-event-loop-fixture-overrides branch October 23, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate event_loop fixture overrides
2 participants