Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made 0.21.1 compatible with pytest 8.2.0 #823

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

ffissore
Copy link

@ffissore ffissore commented Apr 29, 2024

Backported #800 to the 0.21.1 tag
This unblocks all users stuck with 0.21.1 due to #706

As is, this PR can't be merged. A new branch, created from tag 0.21.1, must be created first. Then the base branch of this PR must be changed to that branch

I've run a few test suites locally and these changes work fine: any feedback is welcome

This unblocks all users stuck with 0.21.1 due to pytest-dev#706
wxtim added a commit to wxtim/cylc that referenced this pull request Apr 29, 2024
We cannot use pytest-async 0.23 because of pytest-dev/pytest-asyncio#706
We need to use pytest-async 0.23 if we use pytest 8.2 because of pytest-dev/pytest#12269
This may be fixed bt this backport of the fix in pytest-async 0.23: pytest-dev/pytest-asyncio#823
@seifertm seifertm changed the base branch from main to v0.21.x April 29, 2024 12:31
Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
Copy link
Contributor

@seifertm seifertm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

It makes sense to support pytest-asyncio v0.21 due to the mentioned issue that prevents some users from upgrading.

I branched off v0.21.1, rebased the PR and added a corresponding changelog entry.

@seifertm seifertm merged commit df29481 into pytest-dev:v0.21.x Apr 29, 2024
1 check failed
@Tenzer
Copy link

Tenzer commented Apr 29, 2024

Is the plan to then make a 0.21.2 version that includes this change?

@ffissore ffissore deleted the backport-pytest-8.2-fix branch April 29, 2024 13:30
@ffissore
Copy link
Author

Thank you @seifertm : I just updated a couple of repos to pytest==8.2.0 and pytest-asyncio==0.21.2 and all is well

wxtim added a commit to wxtim/cylc that referenced this pull request Apr 30, 2024
We cannot use pytest-async 0.23 because of pytest-dev/pytest-asyncio#706
We need to use pytest-async 0.23 if we use pytest 8.2 because of pytest-dev/pytest#12269
This may be fixed bt this backport of the fix in pytest-async 0.23: pytest-dev/pytest-asyncio#823

Test MacOs using Python 3.8 becuase GHA no longer providing 3.7 on that platform
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants