Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve detection of multiple event loops being requested in a test #873

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

seifertm
Copy link
Contributor

@seifertm seifertm commented Jul 8, 2024

  • Detect function-scoped loop in addition to larger-scoped loop
  • Detect larger than function-scoped loops in addition to other larger-scoped loops
  • Fix detection in auto mode when asyncio marker is missing

Partially addresses #868

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.08%. Comparing base (b646cc1) to head (84ec512).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #873   +/-   ##
=======================================
  Coverage   92.08%   92.08%           
=======================================
  Files           2        2           
  Lines         480      480           
  Branches       96       96           
=======================================
  Hits          442      442           
  Misses         23       23           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seifertm
Copy link
Contributor Author

seifertm commented Jul 9, 2024

Blocked by #706

…ped loop is pulled in by an async autouse fixture in addition to an event loop with larger scope.

Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
… of a test item.

Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
@seifertm seifertm force-pushed the async-autouse-fixture-triggers-multiple-loop-error branch from bf6f5a7 to bae1d1e Compare August 12, 2024 13:12
…e test.

Previously, the detection was limited to a function-scoped loop and a higher-scoped loop.

Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
@seifertm seifertm force-pushed the async-autouse-fixture-triggers-multiple-loop-error branch from f492fd8 to a70577c Compare August 12, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants