fix target fixture registration post pytest 8.1 #690
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
Contributor
Author
|
AFAIK the build is fine, the error is out of my control and the failure cancelled the other threads: |
2 tasks
jace
added a commit
to hasgeek/funnel
that referenced
this pull request
Aug 20, 2024
Issue: pytest-dev/pytest-bdd#689 Fix: pytest-dev/pytest-bdd#690 Since that issue has been open for months, we incorporate a patch here to be removed when the fix is merged upstream.
This was referenced Aug 20, 2024
jace
added a commit
to hasgeek/funnel
that referenced
this pull request
Aug 20, 2024
Issue: pytest-dev/pytest-bdd#689 Fix: pytest-dev/pytest-bdd#690 Since that issue has been open for months, we incorporate a patch here to be removed when the fix is merged upstream.
Contributor
|
Superseded by #700. Thank you for your effort though, especially the test that reproduced the issue (I copied it into my PR). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #689
Added a test to replicate the issue.
Simply used the same logic pre pytest 8.1 but ajusted the paratemers to create the FixtureDef with expected values post 8.1