Add test to assert that issue 389 is resolved. #744
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tidy up imports in tests in the same file as new test written. Resolves #389
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #744 +/- ##
==========================================
+ Coverage 96.07% 96.09% +0.01%
==========================================
Files 55 55
Lines 2244 2251 +7
Branches 246 246
==========================================
+ Hits 2156 2163 +7
Misses 53 53
Partials 35 35 ☔ View full report in Codecov by Sentry. |
youtux
previously approved these changes
Nov 29, 2024
Make docstring make sense!
youtux
requested changes
Dec 1, 2024
|
|
||
| @given(parsers.parse('Action "{action}" is taken')) | ||
| def take_action1(action): | ||
| print(f'take_action1:{action}') |
There was a problem hiding this comment.
let's use dumb_obj and collect_dumped_obj instead, I made them for exactly this purpose
|
|
||
|
|
||
| def test_same_name_for_step_arg_and_example_parameter(pytester): | ||
| """Test that using the same name for step arg and example parameter works as intended.""" |
There was a problem hiding this comment.
still not clear what we are testing here. Is it about params being filled from example tables vs from parsing the step name?
If so let's make it clearer in the docstring.
Maybe let's also rewrite the step names, like:
- Given foo gets value "A" by the step parser
- Given bar gets value <example_value> from the example table
This would be much clearer to me
There was a problem hiding this comment.
I think the other test is actually testing the same thing and this can be closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tidy up imports in tests in the same file as new test written.
Resolves #389