Relax gherkin-official dep requirement
#753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TypedDict is not a subclass of `dict`, but it is a subclass of `Mapping`. Go figure.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #753 +/- ##
==========================================
+ Coverage 96.01% 96.05% +0.04%
==========================================
Files 55 55
Lines 2359 2359
Branches 250 136 -114
==========================================
+ Hits 2265 2266 +1
Misses 56 56
+ Partials 38 37 -1 ☔ View full report in Codecov by Sentry. |
The-Compiler
added a commit
to qutebrowser/qutebrowser
that referenced
this pull request
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #752
We want to relax the gherkin-official dependency requirement, as right now we use
^29.0.0and it doesn't allow version30to be used, which is annoying since it fixes a warning in python3.13.I will therefore relax it, and add to the tox matrix all the gherkin-official versions we support (right now, 29 and 30).