Remove combining_cov #226
Closed
Remove combining_cov #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
force-pushed
the
fix-combine
branch
2 times, most recently
from
244d77e
to
3d8cf61
Compare
It turns out that this is only required as a workaround to overwriting/setting `self.cov.config.paths['source']` (in a4fc404), which overrides the (relative) value from the config. xdist nodes are still appending their source mapping.
blueyed
force-pushed
the
fix-combine
branch
from
23c7759
to
dfa483d
Compare
|
Closing, it is required for a clean |
|
@blueyed Huh. So the fix was this simple (just remove the source patching)? Would this fix all these complaints people have been making about the new combining behavior in 2.6.0? |
|
@ionelmc (AFAIR one main issue I had was that running "coverage combine" manually on CI would not work anymore, since pytest-cov did it already) |
|
If you are referring to a4fc404#diff-327bb273d551686616daadf60180a4d9R169 being wrong maybe, then that could be the case - I'm not sure about the details currently anymore. |
|
Ah ... nevermind. I thought this was merged (now I see it's just closed). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that this is only required as a workaround to
overwriting/setting
self.cov.config.paths['source'](in a4fc404), whichoverrides the (relative) value from the config.
xdist nodes are still appending their source mapping.