TestCase.skipTest() skips _post_teardown

[lanzz]

TestCase.skipTest() will raise a SkipTest exception, which is not caught in _cleaning_debug, so the _post_teardown() call is skipped. Also apparently cleanups registered with TestCase.addCleanup() will not be run. If setup done in _pre_setup needs to be undone in _post_teardown (or in cleanups scheduled with addCleanup()), that will not happen for tests skipped with skipTest().

This does not apply to tests skipped with a @unittest.skip decorator.

For comparison, nose runs _post_teardown methods for tests skipped with skipTest().

[blueyed]

Thanks for the report.
I assume this works better with Django master (3.1), where this gets handled by Django now? (#773)

Can you provide a failing test, similar to https://github.com/blueyed/pytest-django/blob/c023564e708b5c55b57df43776d21643d1f1f2ce/tests/test_unittest.py#L461-L489 I guess?

[blueyed]

So it's only a problem when using --pdb after all?
In general the finalizer gets used:

pytest-django/pytest_django/fixtures.py

Lines 152 to 153 in c023564

	test_case._pre_setup()
	request.addfinalizer(test_case._post_teardown)

But is skipped explicitly in _cleaning_debug:

pytest-django/pytest_django/plugin.py

Lines 538 to 540 in c023564

	super(cls, self).debug()
	if not skipped:
	self._post_teardown()

[blueyed]

Django does the same: https://github.com/django/django/pull/7436/files#diff-5d7d8ead1a907fe91ffc121f830f2a49R272-R279

This does not apply to tests skipped with a @unittest.skip decorator.

Interesting. Likely because the test is not being invoked in the first place though.

[lanzz]

This might be a bigger issue with pytest itself, it does not run tearDown at all for skipped tests when running with --pdb: pytest-dev/pytest#5991

[blueyed]

pytest-dev/pytest#5996 should fix the issue in pytest.

But pytest-django would still not call self._post_teardown when a test is skipped:

pytest-django/pytest_django/plugin.py

Lines 534 to 538 in 382c6bb

	if not skipped:
	self._pre_setup()
	super(cls, self).debug()
	if not skipped:
	self._post_teardown()

However, with pytest not calling .debug anymore it would only affect you when calling .debug() yourself.

AFAICS _cleaning_debug was only necessary due to the misuse in pytest itself (#406, /cc @asfaltboy).

[blueyed]

Not calling _post_teardown (the Django method) is in line with Django, but I've created django/django#11938 to fix/address this.

[blueyed]

I believe #782 fixes it.
Please test it, I will release it then shortly.

[blueyed]

Releasing as v3.7.0 already..