Allow to use email as USERNAME_FIELD. Tested. #484
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When do you expect to merge it with the master? As I am facing the same problem and for now I have to use a forked version from @gradam. |
When custom user model had 'email' field set as username filed the fixture was resulting in Error `TypeError: create_superuser() got multiple values for argument 'email'`. Additional checking if `username_field` is not equal to 'email' fixed it.
…d on admin_user instead getting username directly.
…me because we had to use custom email field which was not possible when inheriting from AbstractUser
Codecov Report
@@ Coverage Diff @@
## master #484 +/- ##
==========================================
+ Coverage 91.92% 91.97% +0.04%
==========================================
Files 33 33
Lines 1660 1670 +10
Branches 143 143
==========================================
+ Hits 1526 1536 +10
Misses 95 95
Partials 39 39
Continue to review full report at Codecov.
|
|
Do you need anything else for this to be merged? |
jnns
added a commit
to jnns/pytest-django
that referenced
this pull request
May 19, 2020
Related to the following pull requests/issues: pytest-dev#246 pytest-dev#484 pytest-dev#748 pytest-dev#457
jnns
added a commit
to jnns/pytest-django
that referenced
this pull request
May 19, 2020
The previous test setup inherited from AbstractUser thus MyCustomUser still had a username field. The problems people are having when using the admin_client fixture in combination with a custom user model are due to the username field not being present. This change accounts for the more realistic scenario. See these tickets: pytest-dev#246 pytest-dev#484 pytest-dev#748
jnns
added a commit
to jnns/pytest-django
that referenced
this pull request
May 19, 2020
The previous test setup inherited from AbstractUser thus MyCustomUser still had a username field. The problems people are having when using the admin_client fixture in combination with a custom user model are due to the username field not being present. This change accounts for the more realistic scenario. See these tickets: pytest-dev#246 pytest-dev#484 pytest-dev#748
jnns
added a commit
to jnns/pytest-django
that referenced
this pull request
May 19, 2020
The previous test setup inherited from AbstractUser thus MyCustomUser still had a username field. The problems people are having when using the admin_client fixture in combination with a custom user model are due to the username field not being present. This change accounts for the more realistic scenario. See these tickets: pytest-dev#246 pytest-dev#484 pytest-dev#748
jnns
added a commit
to jnns/pytest-django
that referenced
this pull request
May 19, 2020
The previous test setup inherited from AbstractUser thus MyCustomUser still had a username field. The problems people are having when using the admin_client fixture in combination with a custom user model are due to the username field not being present. This change accounts for the more realistic scenario. See these tickets: pytest-dev#246 pytest-dev#484 pytest-dev#748
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow you to use email as username_field.
Also fixed a bug in an admin_client fixture that was caused by using username=admin_user.username instead of admin_user.get_username().