#596 MarkInfo deprecation #603

Code0x58 · 2018-05-29T11:33:40Z

Here is a quick go at removing the deprecation warning mentioned in #596 so tests won't break if running with -W error.

Code0x58 · 2018-05-29T11:34:34Z

pytest_django/plugin.py

@@ -378,10 +378,10 @@ def _django_db_marker(request):
    This will dynamically request the ``db`` or ``transactional_db``
    fixtures as required by the django_db marker.
    """
-    marker = request.keywords.get('django_db', None)


The two places like this bump the requirements to pytest >= 3.6 - I think it would be easy enough to have code branch for pytest < 3.6 to maintain existing compatibility if that feels like a blocker to this PR.

No, I think requiring pytest 3.6 is fine.

Code0x58 · 2018-05-29T11:35:18Z

pytest_django/plugin.py

    if marker:
-        validate_django_db(marker)


I'm not 100% happy with the naming, but I didn't think of anything better.

What naming do you mean?
marker here, or transaction below?
As for transaction it could be named transactional mabye?

I was thinking validate_django_db(…) as it gets a value, and may happen to blow up, but it feels more ok to me now

Code0x58 · 2018-05-29T11:36:15Z

.gitignore

@@ -11,6 +11,7 @@ _build
 /.coverage
 /htmlcov/
 .cache
+.pytest_cache/


This was missing, so added it in a separate commit.

codecov-io · 2018-05-29T11:41:57Z

Codecov Report

Merging #603 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #603   +/-   ##
=======================================
  Coverage   91.92%   91.92%           
=======================================
  Files          33       33           
  Lines        1660     1660           
  Branches      143      143           
=======================================
  Hits         1526     1526           
  Misses         95       95           
  Partials       39       39

Flag	Coverage Δ
#dj110	`83.91% <100%> (ø)`	⬆️
#dj111	`86.08% <100%> (ø)`	⬆️
#dj18	`84.75% <100%> (ø)`	⬆️
#dj19	`83.79% <100%> (ø)`	⬆️
#dj20	`84.21% <100%> (ø)`	⬆️
#djmaster	`84.21% <100%> (ø)`	⬆️
#mysql_innodb	`84.21% <100%> (ø)`	⬆️
#mysql_myisam	`84.15% <100%> (ø)`	⬆️
#postgres	`87.59% <100%> (ø)`	⬆️
#py27	`89.21% <100%> (ø)`	⬆️
#py34	`83.79% <100%> (ø)`	⬆️
#py35	`83.91% <100%> (ø)`	⬆️
#py36	`84.69% <100%> (ø)`	⬆️
#sqlite	`85.96% <100%> (ø)`	⬆️
#sqlite_file	`83.79% <100%> (ø)`	⬆️

Impacted Files	Coverage Δ
pytest_django/plugin.py	`85.75% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bd3d3e...d9a9e9a. Read the comment docs.

Fixes #596.

blueyed · 2018-05-30T18:25:42Z

Merged with changelog entry in 8d548e7.
Thanks!

blueyed · 2018-05-30T18:34:02Z

Don't you see other errors then btw?

Tried it changing the commands for the testenv:

py36-dj20-postgres runtests: commands[0] | python -W error -m pytest --strict -x
Failed to import the site module
Traceback (most recent call last):
  File "…/Vcs/pytest-django/.tox/py36-dj20-postgres/lib/python3.6/site.py", line 703, in <module>
    main()
  File "…/Vcs/pytest-django/.tox/py36-dj20-postgres/lib/python3.6/site.py", line 683, in main
    paths_in_sys = addsitepackages(paths_in_sys)
  File "…/Vcs/pytest-django/.tox/py36-dj20-postgres/lib/python3.6/site.py", line 282, in addsitepackages
    addsitedir(sitedir, known_paths)
  File "…/Vcs/pytest-django/.tox/py36-dj20-postgres/lib/python3.6/site.py", line 204, in addsitedir
    addpackage(sitedir, name, known_paths)
  File "…/Vcs/pytest-django/.tox/py36-dj20-postgres/lib/python3.6/site.py", line 165, in addpackage
    f = open(fullname, "rU")
DeprecationWarning: 'U' mode is deprecated

Looks like this one is coming from Python (3.6.5) itself?!
Fixed for 3.7 in python/cpython@4e86d5b88d9.

Code0x58 · 2018-05-30T22:38:47Z

I didn't encounter that in the environment I was in. It is strange that the patch is 7 years old - it is included in at least the 3.4+ branches on GitHub, but not 2.7, so I think something is up with the environment like 2.7 files are being used.

nirizr · 2018-06-16T07:57:06Z

Hi guys, just an FYI; This PR turned out to be breaking my builds, as it replaces the pytest required version from (the documented, still in README.md) 2.9 up to 3.6.
I wasn't sure this was intended as it isn't noted in either the PR or commit messages, so thought I'd note it here.

blueyed · 2018-06-16T18:30:46Z

@nirizr
Thanks for the notification, I will update the README.

See #603 (comment) - we/I've decided that it's OK to bump it, that's also why it became 3.3.0.
It is also in the release note's title on Github: https://github.com/pytest-dev/pytest-django/releases/tag/3.3.0.

Ref: #603 (comment).

Ref: pytest-dev/pytest-django#603 (comment).

Code0x58 added 2 commits May 29, 2018 12:17

Add .pytest_cache to .gitignore

4902bbb

Issue 596: update to use node.get_closest_marker

d9a9e9a

Code0x58 commented May 29, 2018

View reviewed changes

blueyed merged commit d9a9e9a into pytest-dev:master May 30, 2018

blueyed added a commit that referenced this pull request May 30, 2018

Merge pull request #603 from Code0x58/issue-596-markinfo-deprecation

8d548e7

Fixes #596.

blueyed added the enhancement label May 30, 2018

Code0x58 mentioned this pull request Jun 16, 2018

Update documented pytest requirements changed in d9a9e9a8 #615

Closed

blueyed added a commit that referenced this pull request Jun 16, 2018

README: fix required pytest version

f544f60

Ref: #603 (comment).

beyondgeeks pushed a commit to beyondgeeks/django-pytest that referenced this pull request Sep 6, 2022

README: fix required pytest version

c15f42e

Ref: pytest-dev/pytest-django#603 (comment).

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#596 MarkInfo deprecation #603

#596 MarkInfo deprecation #603

Code0x58 commented May 29, 2018 •

edited

Loading

Code0x58 May 29, 2018

blueyed May 30, 2018

Code0x58 May 29, 2018

blueyed May 30, 2018

Code0x58 May 30, 2018

Code0x58 May 29, 2018

codecov-io commented May 29, 2018

blueyed commented May 30, 2018

blueyed commented May 30, 2018 •

edited

Loading

Code0x58 commented May 30, 2018

nirizr commented Jun 16, 2018 •

edited

Loading

blueyed commented Jun 16, 2018

#596 MarkInfo deprecation #603

#596 MarkInfo deprecation #603

Conversation

Code0x58 commented May 29, 2018 • edited Loading

Code0x58 May 29, 2018

Choose a reason for hiding this comment

blueyed May 30, 2018

Choose a reason for hiding this comment

Code0x58 May 29, 2018

Choose a reason for hiding this comment

blueyed May 30, 2018

Choose a reason for hiding this comment

Code0x58 May 30, 2018

Choose a reason for hiding this comment

Code0x58 May 29, 2018

Choose a reason for hiding this comment

codecov-io commented May 29, 2018

Codecov Report

blueyed commented May 30, 2018

blueyed commented May 30, 2018 • edited Loading

Code0x58 commented May 30, 2018

nirizr commented Jun 16, 2018 • edited Loading

blueyed commented Jun 16, 2018

Code0x58 commented May 29, 2018 •

edited

Loading

blueyed commented May 30, 2018 •

edited

Loading

nirizr commented Jun 16, 2018 •

edited

Loading