Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove py #631

Merged
merged 2 commits into from
Jul 27, 2018
Merged

Remove py #631

merged 2 commits into from
Jul 27, 2018

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Jul 26, 2018

No description provided.

@blueyed blueyed mentioned this pull request Jul 26, 2018
Closed
@codecov-io
Copy link

codecov-io commented Jul 26, 2018 •
edited
Loading

Codecov Report

Merging #631 into master will increase coverage by 0.01%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #631      +/-   ##
==========================================
+ Coverage   92.36%   92.37%   +0.01%     
==========================================
  Files          32       32              
  Lines        1715     1719       +4     
  Branches      142      145       +3     
==========================================
+ Hits         1584     1588       +4     
+ Misses         94       93       -1     
- Partials       37       38       +1
Flag Coverage Δ
#dj110 84.52% <91.66%> (+0.03%) ⬆️
#dj111 86.62% <91.66%> (+0.03%) ⬆️
#dj18 85.34% <91.66%> (+0.03%) ⬆️
#dj19 84.4% <91.66%> (+0.03%) ⬆️
#dj20 84.81% <91.66%> (+0.03%) ⬆️
#dj21 84.81% <91.66%> (+0.03%) ⬆️
#mysql_innodb 84.81% <91.66%> (+0.03%) ⬆️
#mysql_myisam 84.75% <91.66%> (+0.03%) ⬆️
#postgres 88.19% <91.66%> (+0.02%) ⬆️
#py27 89.76% <91.66%> (+0.02%) ⬆️
#py34 84.4% <91.66%> (+0.03%) ⬆️
#py35 84.52% <91.66%> (+0.03%) ⬆️
#py36 85.28% <91.66%> (+0.03%) ⬆️
#sqlite 86.62% <91.66%> (+0.03%) ⬆️
#sqlite_file 84.4% <91.66%> (+0.03%) ⬆️
Impacted Files Coverage Δ
tests/conftest.py 100% <100%> (ø) ⬆️
pytest_django/plugin.py 86.12% <89.47%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e7fc3b...f2ea236. Read the comment docs.

blueyed
blueyed commented Jul 26, 2018
View reviewed changes
pytest_django/plugin.py
return arg
for parent in arg.parents:
if is_django_project(parent):
return parent
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@voidus
This (looking at parent) is a behavior change already, isn't it?
(at least it is not covered with tests)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry.. arg.parts(reverse=True) handled this before

voidus and others added 2 commits July 26, 2018 13:38
@voidus @blueyed
Remove py dependency
ee40819 
py is in maintenance mode and there are modern alternatives.
@blueyed
Add testing extras_require, and move six to it
f2ea236
@blueyed blueyed closed this Jul 26, 2018
@blueyed blueyed reopened this Jul 26, 2018
@blueyed
Copy link
Contributor Author

blueyed commented Jul 26, 2018

@voidus
Please review.

@voidus
Copy link
Contributor

voidus commented Jul 27, 2018

As far as I can see, this looks good. =)

(I just want to mention again that I couldn't get the tests to work on my machine, so don't take my word for it)

@blueyed
Copy link
Contributor Author

blueyed commented Jul 27, 2018

Thanks.

Not even with tox?
E.g. tox -e py36-dj20-postgres should work.
OTOH I've just noticed that the envlist was broken, maybe that caused trouble? (ab5821b)

@blueyed blueyed merged commit 2cb64e9 into pytest-dev:master Jul 27, 2018
@blueyed blueyed deleted the remove-py branch July 27, 2018 10:44
@voidus
Copy link
Contributor

voidus commented Jul 27, 2018

Ah, I probably need a database server running, right? I didn't really have the time to look into it, and I don't really want to run a shared postgres server on my workstation.

@blueyed
Copy link
Contributor Author

blueyed commented Jul 27, 2018

tox -e py36-dj20-sqlite should also work.. :)

@voidus
Copy link
Contributor

voidus commented Jul 30, 2018

That actually worked, thanks. Now I can see that everything passes (with sqlite at least) :)

adamchainz added a commit to adamchainz/pytest-django that referenced this pull request Aug 18, 2018
@adamchainz
Use pathlib2
8726569 
The dependency on `pathlib` was added in pytest-dev#631. A backport is needed for Python <3.4.

The `pathlib` package [on PyPI](https://pypi.org/project/pathlib/) is maintenance-only and comes with a message about using `pathlib2` for an up-to-date version, still importable as `pathlib`. Also `pytest` itself uses `pathlib2` so currently I'm getting both packages installed, one on top of the other, woops!

This change in `setup.py` seems to be all that's needed to switch.
@adamchainz adamchainz mentioned this pull request Aug 18, 2018
Merged
blueyed pushed a commit that referenced this pull request Aug 20, 2018
@adamchainz @blueyed
Use pathlib2 (#636)
43ff7bb 
The dependency on `pathlib` was added in #631. A backport is needed for Python <3.4.

The `pathlib` package [on PyPI](https://pypi.org/project/pathlib/) is maintenance-only and comes with a message about using `pathlib2` for an up-to-date version, still importable as `pathlib`. Also `pytest` itself uses `pathlib2` so currently I'm getting both packages installed, one on top of the other, woops!

This change in `setup.py` seems to be all that's needed to switch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blueyed @codecov-io @voidus