[WIP/RFC] Setup Django only later (pytest_configure) #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required for when conftests are loaded before Django gets setup (i.e. when it would be done in pytest_configure only). Not necessary, but easier to improve things from there.
Codecov Report
@@ Coverage Diff @@
## master #719 +/- ##
=====================================
Coverage 98% 98%
=====================================
Files 32 32
Lines 1853 1853
Branches 147 147
=====================================
Hits 1816 1816
Misses 24 24
Partials 13 13
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #719 +/- ##
=====================================
Coverage 98% 98%
=====================================
Files 32 32
Lines 1853 1853
Branches 147 147
=====================================
Hits 1816 1816
Misses 24 24
Partials 13 13
Continue to review full report at Codecov.
|
blueyed
changed the title
blueyed
commented
Apr 21, 2019
| import django.apps | ||
| assert django.apps.apps.ready | ||
| from tpkg.app.models import Item |
There was a problem hiding this comment.
That's probably a dealbreaker: not being able to import models in your conftest at the toplevel anymore?!
blueyed
changed the title
|
Resorted to using a pytest plugin myself for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.