-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep sort preference for previously sorted columns #220
Conversation
Thanks @wanam Could you add a test for this as well? |
I added 2 assertions to check this issue on |
Could you update with master and fix failing tests @wanam ? |
@BeyondEvil I'm getting some troubles trying to install your CI environment because of a grunt-contrib-qunit's dependency 'puppeteer' that fails to download Chromium module, maybe because I'm behind a proxy... Anyway executing the tests on Chrome browser gave me the same result with the 3 failed tests, this cannot reproduced on my default browser: Firefox, do you have any idea what could be the reason for this? |
js tests and related issues are not my fortay. Maybe @RibeiroAna has some input? If not, I'll see if I can illicit some help from a colleague. 🤷♂ Probably what we should do is replace phantomjs. 🤔 |
I still don't understand why we have different behavior on Firefox vs Chrome, but I just pushed a fix for the sorting issue, the root cause was in case of equal keys, for this case the sort function should return 0. @BeyondEvil If it's ok to merge, could you squash my commits into one commit? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This fixes #219