Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep sort preference for previously sorted columns #220

Merged
merged 4 commits into from
Aug 7, 2019
Merged

Keep sort preference for previously sorted columns #220

merged 4 commits into from
Aug 7, 2019

Conversation

wanam
Copy link
Contributor

@wanam wanam commented Jul 11, 2019

This fixes #219

@BeyondEvil
Copy link
Contributor

Thanks @wanam

Could you add a test for this as well?

@wanam
Copy link
Contributor Author

wanam commented Jul 22, 2019

I added 2 assertions to check this issue on sort_column test.

@BeyondEvil
Copy link
Contributor

Could you update with master and fix failing tests @wanam ?

@wanam
Copy link
Contributor Author

wanam commented Aug 5, 2019

@BeyondEvil I'm getting some troubles trying to install your CI environment because of a grunt-contrib-qunit's dependency 'puppeteer' that fails to download Chromium module, maybe because I'm behind a proxy...

Anyway executing the tests on Chrome browser gave me the same result with the 3 failed tests, this cannot reproduced on my default browser: Firefox, do you have any idea what could be the reason for this?

@BeyondEvil
Copy link
Contributor

BeyondEvil commented Aug 5, 2019

js tests and related issues are not my fortay. Maybe @RibeiroAna has some input?

If not, I'll see if I can illicit some help from a colleague. 🤷‍♂

Probably what we should do is replace phantomjs. 🤔

@wanam
Copy link
Contributor Author

wanam commented Aug 7, 2019

I still don't understand why we have different behavior on Firefox vs Chrome, but I just pushed a fix for the sorting issue, the root cause was in case of equal keys, for this case the sort function should return 0.

@BeyondEvil If it's ok to merge, could you squash my commits into one commit?

Copy link
Contributor

@BeyondEvil BeyondEvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BeyondEvil BeyondEvil merged commit b69dde5 into pytest-dev:master Aug 7, 2019
@ssbarnea ssbarnea added the bug This issue/PR relates to a bug. label Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytest html does not keep sort preference for previously sorted columns
3 participants