Fix assets file naming to work across both *nix and windows #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 4, 2019
BeyondEvil
commented
Aug 4, 2019
davehunt
previously approved these changes
Aug 5, 2019
|
I've asked the people that filed the issues to do some testing on Windows since I don't have access to any windows machines (tried setting something up in a VM, but I've been away from Windows too long). But it would be great if either of you have the possibility to do some smoke-testing? @RibeiroAna @davehunt |
|
@BeyondEvil Your change worked for me as well as it now saves the results correctly without error-ing out. Awesome |
Thanks @EricDelaney ! Awesome, as soon as I can get someone to approve the PR, I'll create a new release. 👍 |
|
ping @davehunt 🙏 |
davehunt
approved these changes
Aug 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of a combination of human readable filename and hash, let's try a filename with cross-OS friendly formatting.
Fixes #214
Fixes #213