Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix min-width which produced horizontal scrolls #237

Merged
merged 2 commits into from
Nov 5, 2019

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Sep 12, 2019

Previous min-width caused undesired horizontal scrolls even on a 5K
display with 1/2 split screen. Reduced value allows users to better
use their screens.

PRevious min-width caused undesired horizontal scrolls even on a 5K
display with 1/2 split screen. Reduced value allows users to better
use their screens.
@BeyondEvil
Copy link
Contributor

Would you mind checking this out @rochacbruno please?

I'm not particularly well versed in CSS, but after having had a quick look - this feels like we're solving a symptom instead of a problem.

Thanks! 🙏

@ssbarnea
Copy link
Member Author

ssbarnea commented Nov 5, 2019

When it comes to CSS there is no perfect solution. In the end there must be a minimal width. I doubt people would be able to read anyoning with a 1px min width. Also having a too big value causes the problem I described. Clearly 1200 is too much, I am not sure if 800 perfect but clearly is better than 1200. ;)

@BeyondEvil
Copy link
Contributor

Yeah, you're probably right @ssbarnea !

This plugin has been around a while now, almost 5 years, and haven't seen much love when it comes to the esthetics.

I wish I had more time, and more knowledge specific to HTML and CSS. I'd like to do a bigger refactor.

Copy link
Contributor

@BeyondEvil BeyondEvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll release this. We can always change it if and when we figure out a better solution.

@BeyondEvil BeyondEvil merged commit ea20a6a into pytest-dev:master Nov 5, 2019
@ssbarnea ssbarnea deleted the fix/1200 branch August 11, 2020 12:57
@ssbarnea ssbarnea added the bug This issue/PR relates to a bug. label Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants