-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger sorting for initial sort column #248
Conversation
Currently it only sets the toggles for initial sort columns without actually doing the sorting. This fixes pytest-dev#247
Would you mind adding a test for the sort? @wanam |
I think it is not necessary to create a new test, it's already covered by this one: https://github.com/pytest-dev/pytest-html/blob/master/testing/test.js#L26 |
Hmm... Does the test fail if you revert your change? 🤔 If not, the test needs to be updated right? @wanam |
The test will still succeed with/without my change, because the 'initial-sort' falg is default set (hard coded here https://github.com/pytest-dev/pytest-html/blob/master/pytest_html/plugin.py#L425) on the first column (test result), if we set this flag for another column, the current test won't pass without my change. |
@BeyondEvil |
Close opened resource. (pytest-dev#235)
Oh yeah you're right. Sorry about that. It's not enough to clone it, you'll have to fiddle with the Gruntfile as well, so let's skip it. Thanks for the PR! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Currently it only sets the toggles for initial sort columns without actually doing the sorting.
This fixes #247