Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop shadowing the 'format' builtin #347

Merged
merged 1 commit into from
Oct 17, 2020
Merged

Stop shadowing the 'format' builtin #347

merged 1 commit into from
Oct 17, 2020

Conversation

gnikonorov
Copy link
Member

Stop shadowing the format builtin function, since this is bad practice.

@gnikonorov gnikonorov added the bug This issue/PR relates to a bug. label Oct 17, 2020
@gnikonorov gnikonorov self-assigned this Oct 17, 2020
@ssbarnea ssbarnea added the major Marks an important and likely breaking change. label Oct 17, 2020
ssbarnea
ssbarnea approved these changes Oct 17, 2020
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok but I labeled it as major due to API change, so we will be reminded to bump major versions when we release. I doubt anyone is really using this plugin API but is better to make it clear and to avoid breaking semantic versioning users.

@ssbarnea ssbarnea merged commit e572bd8 into pytest-dev:master Oct 17, 2020
csm10495 pushed a commit to csm10495/pytest-html that referenced this pull request Oct 23, 2020
@gnikonorov @csm10495
Stop shadowing the 'format' builtin (pytest-dev#347)
3dda7ac
This was referenced Oct 24, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

@BeyondEvil BeyondEvil Awaiting requested review from BeyondEvil

Assignees

@gnikonorov gnikonorov

Labels
bug This issue/PR relates to a bug. major Marks an important and likely breaking change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gnikonorov @ssbarnea