-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Original test cases order kept #512
Original test cases order kept #512
Conversation
[Question] |
Thanks for the PR. 🙏 I'll fix black. 👍 |
Try rebasing with master now. |
Because that sometimes somebody could want to have a possibility to keep the original order of test cases in the report, that possibility was added. The logic is control by specific flag in config file. 1. Added necessary option flag in config. 2. Added necessary logic if flag is set to True. 3. Added necessary tests for new logic. 4. Added additional section in documentation which describes how to turn on the new behaviour.
1. Code formatting fixes via black
d4b1f29
to
840af35
Compare
Rebased and code formatting fixes made by black |
See that tests for py37-windows failed, dunno why... Can we re-run those checks? I closed and re-opened the pull request, probably checks start is waiting for some approval. |
And now it failed for py38-windows. I might just add re-run flaky for windows. |
Hi guys, this feature looks really great and is exactly what I'm looking for. @sygutss @BeyondEvil any update in this PR? See any chance to merge it in near future? Thanks! |
As soon as 4.0.0 is GA (4.0.0rc0 out now!) I'll revisit this. |
Hi @BeyondEvil I've updated to 4.0.0rc1 but it's not like expected in default behavior. Behavior is like the previous approach - By default we have firstly error cases and after them passed cases. After clicking on ordering in that column (header) we can switch opposite - First passed cases after failed cases. There is a lack of the possibility to achieve the original ordering Conclusion - the original ordering is not the default behavior. |
Ok, thanks. I think I initially misunderstood the ask. But OK, I get what you want now. This happens to coincide with #521 So I'll see if I can add a query param to set initial sort order (column, asc/desc, and "original" or something). |
Please try 4.0.0rc4. setting query param ”sort” to ”original” will now sort in execution order. |
Hi @BeyondEvil - I've tested it - in version 4.0.0rc4 and setting query param ”sort” to ”original” the ordering is as expected :) Additional question - will be possible to enforce that behavior as a default one? eg. from the config file? I mean to always open by default the result html file with that ordering without a necessity to setting different ordering by query param manually? |
@BeyondEvil - Up for the previous question and also when is expected to roll out the official version? |
Sorry for the delay. This can be set using addopts and/or ini. And v4 is out. Thanks! 🙏 |
Because that sometimes somebody
could want to have a possibility to
keep the original order of test cases
in the report, that possibility was
added. The logic is control by specific
flag in config file.
which describes how to turn on the new behaviour.