fix: Report fails to render with pytest-xdist (1)

[BeyondEvil]

The reason why the report fails to render when running with pytest-xdist, is that it adds a node attribute with a WorkerController object as its value.

This object is unserializable, so it fails when trying to convert the test data to JSON.

This is proposed solution 1.

Solution 2: #592
Solution 3: #593

There's also the option of making the WorkerController class serializable upstream. Ping @nicoddemus

[nicoddemus]

There's also the option of making the WorkerController class serializable upstream. Ping @nicoddemus

IMHO the WorkerController is an implementation detail and of little to no value to users, so I don't see an advantage in serializing it. 👍

[BeyondEvil]

There's also the option of making the WorkerController class serializable upstream. Ping @nicoddemus

IMHO the WorkerController is an implementation detail and of little to no value to users, so I don't see an advantage in serializing it. 👍

By extension then, I guess there's no point in passing it in the JSON to the report either? (invalidating solution 3 #593 )

[nicoddemus]

Possibly, but more investigation would be needed.

[BeyondEvil]

Possibly, but more investigation would be needed.

I think it's safe to keep it out of the report.

It wasn't part of the legacy report afaict. And if someone has a use case for having it, we can re-add it easily.

[RonnyPfannschmidt]

this is lossy in the face of valid extensions, os i recommend against it

[BeyondEvil]

Fixed by: #598