Fix: Collapsed state between redraws #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeyondEvil
force-pushed
the
beyondevil/store-collapsed-state
branch
from
8b3be90 to
18c7030
Compare
drRedflint
reviewed
Jul 28, 2023
| const tests = Object.values(data.tests).flat().map((test, index) => { | ||
| const collapsed = collapsedCategories.includes(test.result.toLowerCase()) | ||
| const id = `test_${index}` | ||
| if (collapsed) { | ||
| collapsedIds.push(id) |
There was a problem hiding this comment.
I'd avoid updating the collapsedIds collection in the map.
Instead I would do it after the construction of collapsed collection:
const collapsedIds = collapsed.map(({id}) => id)
There was a problem hiding this comment.
or even better:
setCollapsedIds(collapsed.map(({id}) => id))
There was a problem hiding this comment.
I actually had it that way at first. But thought it was better to not do two iterations over the same collection.
drRedflint
reviewed
Jul 28, 2023
| @@ -47,6 +53,10 @@ class DataManager { | |||
| get environment() { | |||
| return this.renderData.environment | |||
| } | |||
|
|
|||
| get initialSort() { | |||
| return this.data.initialSort | |||
There was a problem hiding this comment.
return [...this.data.initialSort]
This prevents data.initialSort from becoming compromised by being updated by reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.