Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify rootdir to recursive pytest calls (fixes #110) #113

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

juliangilbey
Copy link
Contributor

Following a discussion on the pytest issue pytest-dev/pytest#11781 the source of #110 has become a little clearer: the rootdir was set to /tmp, being the common ancestor of the temporary test directory and the invocation directory in the CI environment. This patch specifies the rootdir explicitly.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.29%. Comparing base (19dae40) to head (7e2a507).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   97.21%   98.29%   +1.08%     
==========================================
  Files           5        5              
  Lines         575      588      +13     
  Branches      136      141       +5     
==========================================
+ Hits          559      578      +19     
+ Misses          9        2       -7     
- Partials        7        8       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mrbean-bremen mrbean-bremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Can you add an entry in the release notes?

Copy link
Member

@mrbean-bremen mrbean-bremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mrbean-bremen mrbean-bremen merged commit 225ea45 into pytest-dev:main Apr 2, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants