Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly clear exceptions after test #187

Closed
fabioz opened this issue Sep 24, 2017 · 4 comments
Closed

Properly clear exceptions after test #187

fabioz opened this issue Sep 24, 2017 · 4 comments

Comments

@fabioz
Copy link
Contributor

fabioz commented Sep 24, 2017

If an exception is thrown and is captured by pytestqt, it's keep alive (found it while trying to discover why PySide was crashing on the process exit when a test failed -- the reason was that pytestqt was keeping variables alive longer than it should and variables weren't cleared in the proper order because of that).

Will provide a fix shortly.
fabioz added a commit to fabioz/pytest-qt that referenced this issue Sep 24, 2017
@fabioz
Don't keep exceptions alive after the test finishes
267989e 
Clearing the exceptions found during a test is needed to allow variables to be properly cleared.

Fixes pytest-dev#187
@fabioz fabioz mentioned this issue Sep 24, 2017
Merged
@nicoddemus nicoddemus mentioned this issue Sep 25, 2017
Closed
nicoddemus added a commit to fabioz/pytest-qt that referenced this issue Sep 25, 2017
@nicoddemus
Add a test for exception leakage described in pytest-dev#187
6a76973 
Unfortunately at this moment this is still failing because
of pytest-dev/pytest#2798, we will need to fix this in pytest
first before being able to merge this.
@fabioz
Copy link
Contributor Author

fabioz commented May 29, 2018

Is this fixed now?

@nicoddemus
Copy link
Member

Oh yeah, thanks for the ping. I have fixed the problem in pytest, we should be able to produce a proper test now.

nicoddemus pushed a commit to fabioz/pytest-qt that referenced this issue Jul 12, 2018
@fabioz @nicoddemus
Don't keep exceptions alive after the test finishes
d1ea4b7 
Clearing the exceptions found during a test is needed to allow variables to be properly cleared.

Fixes pytest-dev#187
nicoddemus added a commit to fabioz/pytest-qt that referenced this issue Jul 12, 2018
@nicoddemus
Add a test for exception leakage described in pytest-dev#187
7f0c429 
Unfortunately at this moment this is still failing because
of pytest-dev/pytest#2798, we will need to fix this in pytest
first before being able to merge this.
@nicoddemus
Copy link
Member

Thanks @fabioz, and sorry for the delay!

@fabioz
Copy link
Contributor Author

fabioz commented Jul 13, 2018

No problems. Thanks for the fix ;)

@nicoddemus nicoddemus mentioned this issue Dec 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabioz @nicoddemus