Docs: suggest direct methods instead of qtbot's #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
force-pushed
the
docs-methods-vs-clicks
branch
2 times, most recently
from
c53a4c0 to
1e1a7d5
Compare
Updates the documentation to use direct methods in most interactions, as the documentation currently leads users to call `qtbot`'s methods for normal interactions, such changing the text of a `QLineEdit` or an item of a `QComboBox`. Also changed some code examples to use `.. code-block: python`, so they are formatted by black. Co-authored-by: Florian Bruhin <me@the-compiler.org>
Currently `pyqt6` started to fail during import with this error on `ubuntu-20.04`: ``` INTERNALERROR> ImportError: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.35' not found (required by /home/runner/work/pytest-qt/pytest-qt/.tox/py37-pyqt6/lib/python3.7/site-packages/PyQt6/QtGui.abi3.so) py37-pyqt6: exit 3 (0.27 seconds) /home/runner/work/pytest-qt/pytest-qt> pytest -ra --color=yes pid=2880 ``` Using `ubuntu-latest`, and also re-enabling most jobs except one.
nicoddemus
force-pushed
the
docs-methods-vs-clicks
branch
from
8194231 to
5a75583
Compare
|
Thanks for the review, applied all suggestions. 👍 |
The-Compiler
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the documentation to use direct methods in most interactions, as the documentation currently leads users to call
qtbot's methods for normal interactions, such changing the text of aQLineEditor an item of aQComboBox.Also changed some code examples to use
.. code-block: python, so they are formatted by black.In addition, fixed CI, see commit message 1e1a7d5.
Closes #488.