Drop Python 3.8 support (#650)

Now EOL: https://discuss.python.org/t/python-3-8-is-now-officially-eol/66983 .
pytest-dev · Oct 25, 2024 · bd36771 · bd36771
1 parent d8c3419
commit bd36771
Show file tree

Hide file tree

Showing 10 changed files with 7 additions and 226 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -18,7 +18,6 @@ jobs:
     strategy:
       matrix:
         python-version:
-        - 3.8
         - 3.9
         - '3.10'
         - '3.11'

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -34,7 +34,7 @@ repos:
   rev: v3.17.0
   hooks:
   - id: pyupgrade
-    args: [--py38-plus]
+    args: [--py39-plus]
 - repo: https://github.com/psf/black-pre-commit-mirror
   rev: 24.8.0
   hooks:

diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -2,6 +2,8 @@
 Changelog
 =========
 
+* Drop Python 3.8 support.
+
 3.15.0 (2023-08-15)
 -------------------
 

diff --git a/README.rst b/README.rst
@@ -114,7 +114,7 @@ Install with:
 
     python -m pip install pytest-randomly
 
-Python 3.8 to 3.12 supported.
+Python 3.9 to 3.12 supported.
 
 Usage
 =====

diff --git a/pyproject.toml b/pyproject.toml
@@ -19,15 +19,14 @@ keywords = [
 authors = [
   { name = "Adam Johnson", email = "me@adamj.eu" },
 ]
-requires-python = ">=3.8"
+requires-python = ">=3.9"
 classifiers = [
   "Development Status :: 5 - Production/Stable",
   "Framework :: Pytest",
   "Intended Audience :: Developers",
   "License :: OSI Approved :: MIT License",
   "Natural Language :: English",
   "Programming Language :: Python :: 3 :: Only",
-  "Programming Language :: Python :: 3.8",
   "Programming Language :: Python :: 3.9",
   "Programming Language :: Python :: 3.10",
   "Programming Language :: Python :: 3.11",

diff --git a/src/pytest_randomly/__init__.py b/src/pytest_randomly/__init__.py
@@ -17,8 +17,6 @@
 from pytest import fixture
 from pytest import hookimpl
 
-from pytest_randomly.compat import md5
-
 if sys.version_info < (3, 10):
     from importlib_metadata import entry_points
 else:
@@ -291,7 +289,7 @@ def reduce_list_of_lists(lists: list[list[T]]) -> list[T]:
 
 
 def _md5(string: str) -> bytes:
-    hasher = md5()
+    hasher = hashlib.md5(usedforsecurity=False)
     hasher.update(string.encode())
     return hasher.digest()
 

diff --git a/src/pytest_randomly/compat.py b/src/pytest_randomly/compat.py
diff --git a/tests/requirements/compile.py b/tests/requirements/compile.py
@@ -19,7 +19,6 @@
         *sys.argv[1:],
     ]
     run = partial(subprocess.run, check=True)
-    run([*common_args, "--python", "3.8", "--output-file", "py38.txt"])
     run([*common_args, "--python", "3.9", "--output-file", "py39.txt"])
     run([*common_args, "--python", "3.10", "--output-file", "py310.txt"])
     run([*common_args, "--python", "3.11", "--output-file", "py311.txt"])

diff --git a/tests/requirements/py38.txt b/tests/requirements/py38.txt
diff --git a/tox.ini b/tox.ini
@@ -2,7 +2,7 @@
 requires =
     tox>=4.2
 env_list =
-    py{312, 311, 310, 39, 38}
+    py{312, 311, 310, 39}
 
 [testenv]
 package = wheel
-Original file line number
+Diff line change
@@ Expand Up / @@ -18,7 +18,6 @@ jobs: @@
         strategy:
           matrix:
             python-version:
-            - 3.8
             - 3.9
             - '3.10'
             - '3.11'
@@ Expand Down @@