-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for EOL Python 2.6 #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hugovk! 😁
tox.ini
Outdated
py{27,34,35,36}: pytest | ||
py26: twisted<15.5 | ||
py{27,34,35,36}: twisted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For both pytest
and twisted
dependencies, remove the py{27,34,35,36}:
. It's great I just learned how to make this work in time for py26 support to be removed. :]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:) Done!
README.rst
Outdated
|
||
.. |Pythons| image:: https://img.shields.io/pypi/pyversions/pytest-twisted.svg | ||
:alt: supported Python versions | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure quite what is wrong but these badges don't seem to be loading properly.
https://github.com/hugovk/pytest-twisted/blob/44e308c15510c878b4de2a86e4bd66cbc177550e/README.rst
Maybe it's just a temporary issue and not a source bug? I don't know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a temporary problem with shields.io, I saw this on another repo too. And someone just reported this to shields.io a few minutes ago:
Would you rather these left out for now, or wait a bit longer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, leave it. Maybe update all to the :target:
form though? I have little experience with rst and wasn't aware of that. Definitely seems better though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! :alt:
and :target:
for all.
@hugovk thanks for the tweaks. :] |
@hugovk Awesome, thanks. |
pytest itself has already dropped support for Python 2.6 (in pytest-dev/pytest#2812) as it's been EOL for over four years.
This drops support for Python 2.6 and updates some code to make use of new Python 2.7+ features.