Add empty sentinel item in WorkerInteractor queue #1090
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pytest_runtest_protocol is called with item==nextitem multiple times, with a test that accepts some fixtures -> the second call forward raises an error. This is causes in WorkerInteractor when the same test appears twice in a row in its items queue. To deal with this, we define an "empty" item that shall allow us to call pytest_runtest_protocol with nextitem=None, effectively solving this problem so long sequential executions of the same items are delimited by these empty items in the queue.
|
Much better solution has been proposed in #1091 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pytest_runtest_protocol is called with item==nextitem multiple times, with a test that accepts some fixtures -> the second call forward raises an error.
This is caused in WorkerInteractor when the same test appears twice in a row in the queue.
To deal with this, we define an "empty" item that shall allow us to call pytest_runtest_protocol with nextitem=None, effectively solving this problem so long sequential executions of the same items are delimited by these empty items in the queue.