CI improvements

[nicoddemus]

Improvements based on #905:

• Fix tag creation in deploy workflow
• Use same package in all test runs

[bluetech]

Oops forgot about this 👍

[bluetech]

Testing the actual package (alike) we intent to ship is a good pattern, and from the tox output seems to work as intended.

[RonnyPfannschmidt]

at first glance we only test the sdist and not the wheel

[nicoddemus]

Indeed, but AFAIK this is how it always has been: tox generates both wheel and sdist, but only installs sdist:

λ tox -e py310
...
py310: install_package_deps> python -I -m pip install execnet>=1.1 filelock pytest>=6.2.0
py310: install_package> python -I -m pip install --force-reinstall --no-deps E:\projects\pytest-xdist\.tox\.tmp\package\4\pytest-xdist-3.3.1.dev2+g6d39025.tar.gz
py310: commands[0]> pytest
...

Testing both seems a bit overkill, if that's what you are suggesting.

[RonnyPfannschmidt]

at first glance we only test the sdist and not the wheel

[nicoddemus]

Btw, I could swear I have left a comment regarding this, but here it goes:

I think the next step is to have another job which depends on test, and does the deployment to PyPI under a few conditions:

1. From a branch in the format release-* in the pytest-dev/pytest-xdist repository (upstream, no forks).
2. Also using the deploy environment, meaning that this job will only start after manual approval from @pytest-dev/pytest-xdist-admin (at least 1 person).

This new job would of course replace the deploy workflow.

What do you folks think?