Skip to content

Commit

Permalink
Deprecate --resultlog cmdline option
Browse files Browse the repository at this point in the history
Fix #830
  • Loading branch information
nicoddemus committed Aug 16, 2016
1 parent d3b8551 commit 2408f19
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 1 deletion.
4 changes: 3 additions & 1 deletion _pytest/resultlog.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ def pytest_addoption(parser):
group = parser.getgroup("terminal reporting", "resultlog plugin options")
group.addoption('--resultlog', '--result-log', action="store",
metavar="path", default=None,
help="path for machine-readable result log.")
help="DEPRECATED path for machine-readable result log.")

def pytest_configure(config):
resultlog = config.option.resultlog
Expand All @@ -21,6 +21,8 @@ def pytest_configure(config):
logfile = open(resultlog, 'w', 1) # line buffered
config._resultlog = ResultLog(config, logfile)
config.pluginmanager.register(config._resultlog)
config.warn('C1', '--result-log is deprecated and scheduled for '
'removal in pytest 4.0')

def pytest_unconfigure(config):
resultlog = getattr(config, '_resultlog', None)
Expand Down
4 changes: 4 additions & 0 deletions doc/en/usage.rst
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,10 @@ This will add a property node below the testsuite node to the generated xml:
Creating resultlog format files
----------------------------------------------------

.. deprecated:: 3.0

This option is rarely used and is scheduled for removal in 4.0.

To create plain-text machine-readable result files you can issue::

pytest --resultlog=path
Expand Down
12 changes: 12 additions & 0 deletions testing/deprecated_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,3 +53,15 @@ def pytest_logwarning(self, message):

def test_getfuncargvalue_is_deprecated(request):
pytest.deprecated_call(request.getfuncargvalue, 'tmpdir')


def test_resultlog_is_deprecated(testdir):
result = testdir.runpytest('--help')
result.stdout.fnmatch_lines(['*DEPRECATED path for machine-readable result log*'])

testdir.makepyfile('''
def test():
pass
''')
result = testdir.runpytest('--result-log=%s' % testdir.tmpdir.join('result.log'))
result.stdout.fnmatch_lines(['*--result-log is deprecated and scheduled for removal in pytest 4.0*'])

0 comments on commit 2408f19

Please sign in to comment.