Skip to content

Commit

Permalink
Add hostname and timestamp to JUnit XML testsuite tag (#5692)
Browse files Browse the repository at this point in the history
Add hostname and timestamp to JUnit XML testsuite tag
  • Loading branch information
nicoddemus authored Aug 5, 2019
2 parents 29e336b + cf6632a commit f7e925d
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 0 deletions.
1 change: 1 addition & 0 deletions changelog/5471.feature.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
JUnit XML now includes a timestamp and hostname in the testsuite tag.
4 changes: 4 additions & 0 deletions src/_pytest/junitxml.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,11 @@
"""
import functools
import os
import platform
import re
import sys
import time
from datetime import datetime

import py

Expand Down Expand Up @@ -666,6 +668,8 @@ def pytest_sessionfinish(self):
skipped=self.stats["skipped"],
tests=numtests,
time="%.3f" % suite_time_delta,
timestamp=datetime.fromtimestamp(self.suite_start_time).isoformat(),
hostname=platform.node(),
)
logfile.write(Junit.testsuites([suite_node]).unicode(indent=0))
logfile.close()
Expand Down
26 changes: 26 additions & 0 deletions testing/test_junitxml.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import os
import platform
from datetime import datetime
from xml.dom import minidom

import py
Expand Down Expand Up @@ -139,6 +141,30 @@ def test_xpass():
node = dom.find_first_by_tag("testsuite")
node.assert_attr(name="pytest", errors=1, failures=2, skipped=1, tests=5)

def test_hostname_in_xml(self, testdir):
testdir.makepyfile(
"""
def test_pass():
pass
"""
)
result, dom = runandparse(testdir)
node = dom.find_first_by_tag("testsuite")
node.assert_attr(hostname=platform.node())

def test_timestamp_in_xml(self, testdir):
testdir.makepyfile(
"""
def test_pass():
pass
"""
)
start_time = datetime.now()
result, dom = runandparse(testdir)
node = dom.find_first_by_tag("testsuite")
timestamp = datetime.strptime(node["timestamp"], "%Y-%m-%dT%H:%M:%S.%f")
assert start_time <= timestamp < datetime.now()

def test_timing_function(self, testdir):
testdir.makepyfile(
"""
Expand Down

0 comments on commit f7e925d

Please sign in to comment.