-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Improve warning stacklevel #12014
Conversation
Okay added a test, rebased, and targeted |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lovely enhancement 👍
please add a changelog fragment for towncrier, you can use the pr id as issue id
also do you want to rebase/squash or should we
Stub added, feel free to squash at your end! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @larsoner!
* ENH: Improve warning stacklevel * TST: Add test * TST: Ping * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * MAINT: Changelog --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Include documentation when adding new features.AUTHORS
in alphabetical order.This is really proposal-by-PR (because the PR is pretty trivial). In MNE-Python at least it takes this warning on 8.0.1:
and puts it on the correct line needed to fix the warning
Happy to add to some test if people think this is a good idea and will work in the general case. Happy to explore if it will work in some cases (esp. if someone can point me to the right place to add a test!).
Can also rebase and re-target for
main
but on my machine at least I get a cryptic error when I try to use latestmain
with MNE-Python so haven't done that for now.