How to return from hookwrapper in python < 3.3

[fruch]

I have a warning that _multicall is deprecated, so I have to change the code I have

@pytest.hookimpl(tryfirst=True)
def pytest_runtest_makereport(___multicall__):
    # Execute all other hooks to obtain the report object.
    rep = ___multicall__.execute()
    if rep.failed:
            # my logic to figure out I want to xfail
            if 'decided I want to xfail':
                TestApi.add_analysis('socket hang up')
                setattr(rep, "outcome", "skipped")
                setattr(rep, "wasxfail", 'socket hang up')
                return rep
    return rep

to this code:

@pytest.hookimpl(tryfirst=True, hookwrapper=True)
def pytest_runtest_makereport():
    # Execute all other hooks to obtain the report object.
    outcome = yield
    rep = outcome.get_result()
    if rep.failed:
            # my logic to figure out I want to xfail
            if 'decided I want to xfail':
                TestApi.add_analysis('socket hang up')
                setattr(rep, "outcome", "skipped")
                setattr(rep, "wasxfail", 'socket hang up')
                return rep
    return rep

problem python < 3.3 doesn't support returning from a generator, so how am I supposued to return a modified result ?
changing the object in-place would be enough ?

[fruch]

after looking at skipping.py seem like changing in place does work.

but that's the way to return anything in python < 3.3

[nicoddemus]

@fruch use outcome.force_result when changing in-place is not feasible/desired.

[fruch]

can you point to example of this api ?

[nicoddemus]

Sure, here: http://pluggy.readthedocs.io/en/latest/#wrappers

I'm opening a PR to add this to pytest's docs too.

[nicoddemus]

Opened #3177, please take a look.

[fruch]

I'm happy now, closing...