RuntimeError: maximum recursion depth exceeded .... on Windows and Python 2.7 #3506

pombredanne · 2018-05-25T08:34:21Z

I bumped pytest from 3.5.1 to 3.6.0 ... and the tests fail to run on Windows with a pytest error:

RuntimeError: maximum recursion depth exceeded

If I uninstall 3.6.0 and reinstall 3.5.1 things are back to normal.

See https://ci.appveyor.com/project/nexB/license-expression/build/248/job/smx1qy33w1dxrlh5#L531
and https://ci.appveyor.com/project/nexB/license-expression/build/248/job/jpd8c35tgee9mi7y#L532

Things work fine on POSIX and other Python versions on Windows:
https://travis-ci.org/nexB/license-expression/builds/383421178
https://ci.appveyor.com/project/nexB/license-expression/build/248

The exact versions and wheel of all the thirdparty packages used are here:
https://github.com/nexB/license-expression/tree/fix-symbol-comparison/thirdparty/dev
https://github.com/nexB/license-expression/tree/fix-symbol-comparison/thirdparty/base

The text was updated successfully, but these errors were encountered:

pytestbot · 2018-05-25T08:38:29Z

GitMate.io thinks possibly related issues are #2501 (maximum recursion depth exceeded), #2327 (capsys not capturing on Python 2.7), #3 (not executable on Python 2.7), #323 (Parametrization leads to RuntimeError: maximum recursion depth exceeded), and #2642 (Introduce six to the codebase to deal with Python 2/Python 3 differences).

work around bug pytest-dev/pytest#3506 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

nicoddemus · 2018-05-25T20:23:05Z

Hi @pombredanne,

Here's the interesting part of the traceback:

  File "c:\projects\license-expression\lib\site-packages\_pytest\assertion\rewrite.py", line 271, in _write_pyc
    marshal.dump(co, fp)
  File "C:\Python27\Lib\contextlib.py", line 24, in __exit__
    self.gen.next()
  File "c:\projects\license-expression\lib\site-packages\atomicwrites\__init__.py", line 152, in _open
    self.commit(f)
  File "c:\projects\license-expression\lib\site-packages\atomicwrites\__init__.py", line 177, in commit
    replace_atomic(f.name, self._path)
  File "c:\projects\license-expression\lib\site-packages\atomicwrites\__init__.py", line 89, in replace_atomic
    return _replace_atomic(src, dst)
  File "c:\projects\license-expression\lib\site-packages\atomicwrites\__init__.py", line 70, in _replace_atomic
    _path_to_unicode(src), _path_to_unicode(dst),
  File "c:\projects\license-expression\lib\site-packages\atomicwrites\__init__.py", line 21, in _path_to_unicode
    return x.decode(sys.getfilesystemencoding())
  File "c:\projects\license-expression\lib\encodings\__init__.py", line 100, in search_function
    level=0)
  File "c:\projects\license-expression\lib\site-packages\_pytest\assertion\rewrite.py", line 145, in find_module
    _write_pyc(state, co, source_stat, pyc)

c:\projects\license-expression\lib\encodings\__init__.py", line 100 is:

        try:
            # Import is absolute to prevent the possibly malicious import of a
            # module with side-effects that is not in the 'encodings' package.
            mod = __import__('encodings.' + modname, fromlist=_import_tail,
                             level=0)
        except ImportError:

So when atomicwrites tries to write the file, this triggers an import, which triggers the rewriter again, and so on.

I will have to think how to solve this...

nicoddemus · 2018-05-25T20:27:19Z

Hmmm possibly a fix is to call sys.getfilesystemencoding() before the atomicwrite call.

Any chance of providing a reproducible example @pombredanne? Alternatively, I can push an experiment to my fork and you can install pytest from there to see if it works?

pombredanne · 2018-05-25T21:53:21Z

@nicoddemus I can reproduce things at this commit exactly aboutcode-org/license-expression@e4040b3
The difficulty would be to find a trimmed down example .... though the license-expression library is rather simple: just two python files and one dep and only two test files.

nicoddemus · 2018-05-25T22:31:07Z

No problem, would it be easy for you to install pytest from my fork at a specific branch?

pombredanne · 2018-05-27T14:53:29Z

@nicoddemus sure, I can tweak a branch alright to get any custom py.test installed.

stevepiercy · 2018-08-27T03:42:10Z

FWIW, this issue affects all three of the Pyramid cookiecutters.

This commit is testing to ensure the fix for issue pytest-dev/pytest#3506 actually works.

nicoddemus · 2018-08-27T23:58:04Z

Thanks @stevepiercy, this issue got off my radar.

I've opened Pylons/pyramid-cookiecutter-starter#56 to test a candidate fix. This works locally, but I want to make sure.

No idea how I will test for this though...

…write What happens is that atomic_write on Python 2.7 on Windows will try to convert the paths to unicode, but this triggers the import of the encoding module for the file system codec, which in turn triggers the rewrite, which in turn again tries to import the module, and so on. This short-circuits the cases where we try to import another file when writing a pyc file; I don't expect this to affect anything because the only modules that could be affected are those imported by atomic_writes. Fix pytest-dev#3506

This PR updates [pytest](https://pypi.org/project/pytest) from **3.7.3** to **3.7.4**. <details> <summary>Changelog</summary> ### 3.7.4 ``` ========================= Bug Fixes --------- - `3506 <https://github.com/pytest-dev/pytest/issues/3506>`_: Fix possible infinite recursion when writing ``.pyc`` files. - `3853 <https://github.com/pytest-dev/pytest/issues/3853>`_: Cache plugin now obeys the ``-q`` flag when ``--last-failed`` and ``--failed-first`` flags are used. - `3883 <https://github.com/pytest-dev/pytest/issues/3883>`_: Fix bad console output when using ``console_output_style=classic``. - `3888 <https://github.com/pytest-dev/pytest/issues/3888>`_: Fix macOS specific code using ``capturemanager`` plugin in doctests. Improved Documentation ---------------------- - `3902 <https://github.com/pytest-dev/pytest/issues/3902>`_: Fix pytest.org links ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pytest - Changelog: https://pyup.io/changelogs/pytest/ - Homepage: https://docs.pytest.org/en/latest/ </details>

This PR updates [pytest](https://pypi.org/project/pytest) from **3.7.2** to **3.7.4**. <details> <summary>Changelog</summary> ### 3.7.4 ``` ========================= Bug Fixes --------- - `3506 <https://github.com/pytest-dev/pytest/issues/3506>`_: Fix possible infinite recursion when writing ``.pyc`` files. - `3853 <https://github.com/pytest-dev/pytest/issues/3853>`_: Cache plugin now obeys the ``-q`` flag when ``--last-failed`` and ``--failed-first`` flags are used. - `3883 <https://github.com/pytest-dev/pytest/issues/3883>`_: Fix bad console output when using ``console_output_style=classic``. - `3888 <https://github.com/pytest-dev/pytest/issues/3888>`_: Fix macOS specific code using ``capturemanager`` plugin in doctests. Improved Documentation ---------------------- - `3902 <https://github.com/pytest-dev/pytest/issues/3902>`_: Fix pytest.org links ``` ### 3.7.3 ``` ========================= Bug Fixes --------- - `3033 <https://github.com/pytest-dev/pytest/issues/3033>`_: Fixtures during teardown can again use ``capsys`` and ``capfd`` to inspect output captured during tests. - `3773 <https://github.com/pytest-dev/pytest/issues/3773>`_: Fix collection of tests from ``__init__.py`` files if they match the ``python_files`` configuration option. - `3796 <https://github.com/pytest-dev/pytest/issues/3796>`_: Fix issue where teardown of fixtures of consecutive sub-packages were executed once, at the end of the outer package. - `3816 <https://github.com/pytest-dev/pytest/issues/3816>`_: Fix bug where ``--show-capture=no`` option would still show logs printed during fixture teardown. - `3819 <https://github.com/pytest-dev/pytest/issues/3819>`_: Fix ``stdout/stderr`` not getting captured when real-time cli logging is active. - `3843 <https://github.com/pytest-dev/pytest/issues/3843>`_: Fix collection error when specifying test functions directly in the command line using ``test.py::test`` syntax together with ``--doctest-modules``. - `3848 <https://github.com/pytest-dev/pytest/issues/3848>`_: Fix bugs where unicode arguments could not be passed to ``testdir.runpytest`` on Python 2. - `3854 <https://github.com/pytest-dev/pytest/issues/3854>`_: Fix double collection of tests within packages when the filename starts with a capital letter. Improved Documentation ---------------------- - `3824 <https://github.com/pytest-dev/pytest/issues/3824>`_: Added example for multiple glob pattern matches in ``python_files``. - `3833 <https://github.com/pytest-dev/pytest/issues/3833>`_: Added missing docs for ``pytester.Testdir``. - `3870 <https://github.com/pytest-dev/pytest/issues/3870>`_: Correct documentation for setuptools integration. Trivial/Internal Changes ------------------------ - `3826 <https://github.com/pytest-dev/pytest/issues/3826>`_: Replace broken type annotations with type comments. - `3845 <https://github.com/pytest-dev/pytest/issues/3845>`_: Remove a reference to issue `568 <https://github.com/pytest-dev/pytest/issues/568>`_ from the documentation, which has since been fixed. ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pytest - Changelog: https://pyup.io/changelogs/pytest/ - Homepage: https://docs.pytest.org/en/latest/ </details>

This PR updates [pytest](https://pypi.org/project/pytest) from **3.7.3** to **3.7.4**. <details> <summary>Changelog</summary> ### 3.7.4 ``` ========================= Bug Fixes --------- - `3506 <https://github.com/pytest-dev/pytest/issues/3506>`_: Fix possible infinite recursion when writing ``.pyc`` files. - `3853 <https://github.com/pytest-dev/pytest/issues/3853>`_: Cache plugin now obeys the ``-q`` flag when ``--last-failed`` and ``--failed-first`` flags are used. - `3883 <https://github.com/pytest-dev/pytest/issues/3883>`_: Fix bad console output when using ``console_output_style=classic``. - `3888 <https://github.com/pytest-dev/pytest/issues/3888>`_: Fix macOS specific code using ``capturemanager`` plugin in doctests. Improved Documentation ---------------------- - `3902 <https://github.com/pytest-dev/pytest/issues/3902>`_: Fix pytest.org links ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pytest - Changelog: https://pyup.io/changelogs/pytest/ - Homepage: https://docs.pytest.org/en/latest/ </details>

30: Update pytest to 3.7.4 r=rehandalal a=pyup-bot This PR updates [pytest](https://pypi.org/project/pytest) from **3.7.3** to **3.7.4**. <details> <summary>Changelog</summary> ### 3.7.4 ``` ========================= Bug Fixes --------- - `3506 <https://github.com/pytest-dev/pytest/issues/3506>`_: Fix possible infinite recursion when writing ``.pyc`` files. - `3853 <https://github.com/pytest-dev/pytest/issues/3853>`_: Cache plugin now obeys the ``-q`` flag when ``--last-failed`` and ``--failed-first`` flags are used. - `3883 <https://github.com/pytest-dev/pytest/issues/3883>`_: Fix bad console output when using ``console_output_style=classic``. - `3888 <https://github.com/pytest-dev/pytest/issues/3888>`_: Fix macOS specific code using ``capturemanager`` plugin in doctests. Improved Documentation ---------------------- - `3902 <https://github.com/pytest-dev/pytest/issues/3902>`_: Fix pytest.org links ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pytest - Changelog: https://pyup.io/changelogs/pytest/ - Homepage: https://docs.pytest.org/en/latest/ </details> Co-authored-by: pyup-bot <github-bot@pyup.io>

### Update [wheel](https://pypi.org/project/wheel) from **0.31.1** to **0.32.0**. <details> <summary>Changelog</summary> ### 0.32.0 ``` - Removed wheel signing and verifying features - Removed the "wheel install" and "wheel installscripts" commands - Added the ``wheel pack`` command - Allowed multiple license files to be specified using the ``license_files`` option - Deprecated the ``license_file`` option - Eliminated duplicate lines from generated requirements in ``.dist-info/METADATA`` (thanks to Wim Glenn for the contribution) - Fixed handling of direct URL specifiers in requirements (PR by Benoit Pierre) - Fixed canonicalization of extras (PR by Benoit Pierre) - Warn when the deprecated ``[wheel]`` section is used in ``setup.cfg`` (PR by Jon Dufresne) ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/wheel - Changelog: https://pyup.io/changelogs/wheel/ - Repo: https://github.com/pypa/wheel </details> ### Update [watchdog](https://pypi.org/project/watchdog) from **0.8.3** to **0.9.0**. *The bot wasn't able to find a changelog for this release. [Got an idea?](https://github.com/pyupio/changelogs/issues/new)* <details> <summary>Links</summary> - PyPI: https://pypi.org/project/watchdog - Changelog: https://pyup.io/changelogs/watchdog/ - Repo: http://github.com/gorakhargosh/watchdog - Docs: https://pythonhosted.org/watchdog/ </details> ### Update [Sphinx](https://pypi.org/project/Sphinx) from **1.7.6** to **1.8.1**. <details> <summary>Changelog</summary> ### 1.8.1 ``` ===================================== Incompatible changes -------------------- * LaTeX ``\pagestyle`` commands have been moved to the LaTeX template. No changes in PDF, except possibly if ``\sphinxtableofcontents``, which contained them, had been customized in :file:`conf.py`. (refs: 5455) Bugs fixed ---------- * 5418: Incorrect default path for sphinx-build -d/doctrees files * 5421: autodoc emits deprecation warning for :confval:`autodoc_default_flags` * 5422: lambda object causes PicklingError on storing environment * 5417: Sphinx fails to build with syntax error in Python 2.7.5 * 4911: add latexpdf to make.bat for non make-mode * 5436: Autodoc does not work with enum subclasses with properties/methods * 5437: autodoc: crashed on modules importing eggs * 5433: latex: ImportError: cannot import name 'DEFAULT_SETTINGS' * 5431: autodoc: ``autofunction`` emits a warning for callable objects * 5457: Fix TypeError in error message when override is prohibited * 5453: PDF builds of 'howto' documents have no page numbers * 5463: mathbase: math_role and MathDirective was disappeared in 1.8.0 * 5454: latex: Index has disappeared from PDF for Japanese documents * 5432: py domain: ``:type:`` field can't process ``:term:`` references * 5426: py domain: TypeError has been raised for class attribute ``` ### 1.8.0 ``` ===================================== Dependencies ------------ ``` ### 1.8.0b2 ``` * html: search box overrides to other elements if scrolled * i18n: warnings for translation catalogs have wrong line numbers (refs: 5321) * 5325: latex: cross references has been broken by multiply labeled objects * C++, fixes for symbol addition and lookup. Lookup should no longer break in partial builds. See also 5337. * 5348: download reference to remote file is not displayed * 5282: html theme: ``pygments_style`` of theme was overrided by ``conf.py`` by default * 4379: toctree shows confusible warning when document is excluded * 2401: autodoc: ``:members:`` causes ``:special-members:`` not to be shown * autodoc: ImportError is replaced by AttributeError for deeper module * 2720, 4034: Incorrect links with ``:download:``, duplicate names, and parallel builds * 5290: autodoc: failed to analyze source code in egg package * 5399: Sphinx crashes if unknown po file exists ``` ### 1.8.0b1 ``` * 5083: Fix wrong make.bat option for internationalization. * 5115: napoleon: add admonitions added by 4613 to the docs. ``` ### 1.7.10 ``` =============================== Dependencies ------------ Incompatible changes -------------------- Deprecated ---------- Features added -------------- Bugs fixed ---------- Testing -------- ``` ### 1.7.9 ``` ===================================== Features added -------------- * 5359: Make generated texinfo files reproducible by sorting the anchors Bugs fixed ---------- * 5361: crashed on incremental build if document uses include directive ``` ### 1.7.8 ``` ===================================== Incompatible changes -------------------- * The type of ``env.included`` has been changed to dict of set Bugs fixed ---------- * 5320: intersphinx: crashed if invalid url given * 5326: manpage: crashed when invalid docname is specified as ``man_pages`` * 5322: autodoc: ``Any`` typehint causes formatting error * 5327: "document isn't included in any toctree" warning on rebuild with generated files * 5335: quickstart: escape sequence has been displayed with MacPorts' python ``` ### 1.7.7 ``` ===================================== Bugs fixed ---------- * 5198: document not in toctree warning when including files only for parallel builds * LaTeX: reduce "Token not allowed in a PDF string" hyperref warnings in latex console output (refs: 5236) * LaTeX: suppress "remreset Warning: The remreset package is obsolete" in latex console output with recent LaTeX (refs: 5237) * 5234: PDF output: usage of PAPER environment variable is broken since Sphinx 1.5 * LaTeX: fix the :confval:`latex_engine` documentation regarding Latin Modern font with XeLaTeX/LuaLateX (refs: 5251) * 5280: autodoc: Fix wrong type annotations for complex typing * autodoc: Optional types are wrongly rendered * 5291: autodoc crashed by ForwardRef types * 5211: autodoc: No docs generated for functools.partial functions * 5306: autodoc: ``getargspec()`` raises NameError for invalid typehints * 5298: imgmath: math_number_all causes equations to have two numbers in html * 5294: sphinx-quickstart blank prompts in PowerShell ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/sphinx - Changelog: https://pyup.io/changelogs/sphinx/ - Homepage: http://sphinx-doc.org/ </details> ### Update [py](https://pypi.org/project/py) from **1.5.3** to **1.6.0**. <details> <summary>Changelog</summary> ### 1.6.0 ``` ================== - add ``TerminalWriter.width_of_current_line`` (i18n version of ``TerminalWriter.chars_on_current_line``), a read-only property that tracks how wide the current line is, attempting to take into account international characters in the calculation. ``` ### 1.5.4 ``` ================== - fix pytest-dev/pytest3451: don't make assumptions about fs case sensitivity in ``make_numbered_dir``. ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/py - Changelog: https://pyup.io/changelogs/py/ - Docs: http://py.readthedocs.io/ </details> ### Update [pytest](https://pypi.org/project/pytest) from **3.7.0** to **3.8.1**. <details> <summary>Changelog</summary> ### 3.8.1 ``` ========================= Bug Fixes --------- - `3286 <https://github.com/pytest-dev/pytest/issues/3286>`_: ``.pytest_cache`` directory is now automatically ignored by Git. Users who would like to contribute a solution for other SCMs please consult/comment on this issue. - `3749 <https://github.com/pytest-dev/pytest/issues/3749>`_: Fix the following error during collection of tests inside packages:: TypeError: object of type 'Package' has no len() - `3941 <https://github.com/pytest-dev/pytest/issues/3941>`_: Fix bug where indirect parametrization would consider the scope of all fixtures used by the test function to determine the parametrization scope, and not only the scope of the fixtures being parametrized. - `3973 <https://github.com/pytest-dev/pytest/issues/3973>`_: Fix crash of the assertion rewriter if a test changed the current working directory without restoring it afterwards. - `3998 <https://github.com/pytest-dev/pytest/issues/3998>`_: Fix issue that prevented some caplog properties (for example ``record_tuples``) from being available when entering the debugger with ``--pdb``. - `3999 <https://github.com/pytest-dev/pytest/issues/3999>`_: Fix ``UnicodeDecodeError`` in python2.x when a class returns a non-ascii binary ``__repr__`` in an assertion which also contains non-ascii text. Improved Documentation ---------------------- - `3996 <https://github.com/pytest-dev/pytest/issues/3996>`_: New `Deprecations and Removals <https://docs.pytest.org/en/latest/deprecations.html>`_ page shows all currently deprecated features, the rationale to do so, and alternatives to update your code. It also list features removed from pytest in past major releases to help those with ancient pytest versions to upgrade. Trivial/Internal Changes ------------------------ - `3955 <https://github.com/pytest-dev/pytest/issues/3955>`_: Improve pre-commit detection for changelog filenames - `3975 <https://github.com/pytest-dev/pytest/issues/3975>`_: Remove legacy code around im_func as that was python2 only ``` ### 3.8.0 ``` ========================= Deprecations and Removals ------------------------- - `2452 <https://github.com/pytest-dev/pytest/issues/2452>`_: ``Config.warn`` and ``Node.warn`` have been deprecated, see `<https://docs.pytest.org/en/latest/deprecations.htmlconfig-warn-and-node-warn>`_ for rationale and examples. - `3936 <https://github.com/pytest-dev/pytest/issues/3936>`_: ``pytest.mark.filterwarnings`` second parameter is no longer regex-escaped, making it possible to actually use regular expressions to check the warning message. **Note**: regex-escaping the match string was an implementation oversight that might break test suites which depend on the old behavior. Features -------- - `2452 <https://github.com/pytest-dev/pytest/issues/2452>`_: Internal pytest warnings are now issued using the standard ``warnings`` module, making it possible to use the standard warnings filters to manage those warnings. This introduces ``PytestWarning``, ``PytestDeprecationWarning`` and ``RemovedInPytest4Warning`` warning types as part of the public API. Consult `the documentation <https://docs.pytest.org/en/latest/warnings.htmlinternal-pytest-warnings>`_ for more info. - `2908 <https://github.com/pytest-dev/pytest/issues/2908>`_: ``DeprecationWarning`` and ``PendingDeprecationWarning`` are now shown by default if no other warning filter is configured. This makes pytest more compliant with `PEP-0506 <https://www.python.org/dev/peps/pep-0565/recommended-filter-settings-for-test-runners>`_. See `the docs <https://docs.pytest.org/en/latest/warnings.htmldeprecationwarning-and-pendingdeprecationwarning>`_ for more info. - `3251 <https://github.com/pytest-dev/pytest/issues/3251>`_: Warnings are now captured and displayed during test collection. - `3784 <https://github.com/pytest-dev/pytest/issues/3784>`_: ``PYTEST_DISABLE_PLUGIN_AUTOLOAD`` environment variable disables plugin auto-loading when set. - `3829 <https://github.com/pytest-dev/pytest/issues/3829>`_: Added the ``count`` option to ``console_output_style`` to enable displaying the progress as a count instead of a percentage. - `3837 <https://github.com/pytest-dev/pytest/issues/3837>`_: Added support for 'xfailed' and 'xpassed' outcomes to the ``pytester.RunResult.assert_outcomes`` signature. Bug Fixes --------- - `3911 <https://github.com/pytest-dev/pytest/issues/3911>`_: Terminal writer now takes into account unicode character width when writing out progress. - `3913 <https://github.com/pytest-dev/pytest/issues/3913>`_: Pytest now returns with correct exit code (EXIT_USAGEERROR, 4) when called with unknown arguments. - `3918 <https://github.com/pytest-dev/pytest/issues/3918>`_: Improve performance of assertion rewriting. Improved Documentation ---------------------- - `3566 <https://github.com/pytest-dev/pytest/issues/3566>`_: Added a blurb in usage.rst for the usage of -r flag which is used to show an extra test summary info. - `3907 <https://github.com/pytest-dev/pytest/issues/3907>`_: Corrected type of the exceptions collection passed to ``xfail``: ``raises`` argument accepts a ``tuple`` instead of ``list``. Trivial/Internal Changes ------------------------ - `3853 <https://github.com/pytest-dev/pytest/issues/3853>`_: Removed ``"run all (no recorded failures)"`` message printed with ``--failed-first`` and ``--last-failed`` when there are no failed tests. ``` ### 3.7.4 ``` ========================= Bug Fixes --------- - `3506 <https://github.com/pytest-dev/pytest/issues/3506>`_: Fix possible infinite recursion when writing ``.pyc`` files. - `3853 <https://github.com/pytest-dev/pytest/issues/3853>`_: Cache plugin now obeys the ``-q`` flag when ``--last-failed`` and ``--failed-first`` flags are used. - `3883 <https://github.com/pytest-dev/pytest/issues/3883>`_: Fix bad console output when using ``console_output_style=classic``. - `3888 <https://github.com/pytest-dev/pytest/issues/3888>`_: Fix macOS specific code using ``capturemanager`` plugin in doctests. Improved Documentation ---------------------- - `3902 <https://github.com/pytest-dev/pytest/issues/3902>`_: Fix pytest.org links ``` ### 3.7.3 ``` ========================= Bug Fixes --------- - `3033 <https://github.com/pytest-dev/pytest/issues/3033>`_: Fixtures during teardown can again use ``capsys`` and ``capfd`` to inspect output captured during tests. - `3773 <https://github.com/pytest-dev/pytest/issues/3773>`_: Fix collection of tests from ``__init__.py`` files if they match the ``python_files`` configuration option. - `3796 <https://github.com/pytest-dev/pytest/issues/3796>`_: Fix issue where teardown of fixtures of consecutive sub-packages were executed once, at the end of the outer package. - `3816 <https://github.com/pytest-dev/pytest/issues/3816>`_: Fix bug where ``--show-capture=no`` option would still show logs printed during fixture teardown. - `3819 <https://github.com/pytest-dev/pytest/issues/3819>`_: Fix ``stdout/stderr`` not getting captured when real-time cli logging is active. - `3843 <https://github.com/pytest-dev/pytest/issues/3843>`_: Fix collection error when specifying test functions directly in the command line using ``test.py::test`` syntax together with ``--doctest-modules``. - `3848 <https://github.com/pytest-dev/pytest/issues/3848>`_: Fix bugs where unicode arguments could not be passed to ``testdir.runpytest`` on Python 2. - `3854 <https://github.com/pytest-dev/pytest/issues/3854>`_: Fix double collection of tests within packages when the filename starts with a capital letter. Improved Documentation ---------------------- - `3824 <https://github.com/pytest-dev/pytest/issues/3824>`_: Added example for multiple glob pattern matches in ``python_files``. - `3833 <https://github.com/pytest-dev/pytest/issues/3833>`_: Added missing docs for ``pytester.Testdir``. - `3870 <https://github.com/pytest-dev/pytest/issues/3870>`_: Correct documentation for setuptools integration. Trivial/Internal Changes ------------------------ - `3826 <https://github.com/pytest-dev/pytest/issues/3826>`_: Replace broken type annotations with type comments. - `3845 <https://github.com/pytest-dev/pytest/issues/3845>`_: Remove a reference to issue `568 <https://github.com/pytest-dev/pytest/issues/568>`_ from the documentation, which has since been fixed. ``` ### 3.7.2 ``` ========================= Bug Fixes --------- - `3671 <https://github.com/pytest-dev/pytest/issues/3671>`_: Fix ``filterwarnings`` not being registered as a builtin mark. - `3768 <https://github.com/pytest-dev/pytest/issues/3768>`_, `3789 <https://github.com/pytest-dev/pytest/issues/3789>`_: Fix test collection from packages mixed with normal directories. - `3771 <https://github.com/pytest-dev/pytest/issues/3771>`_: Fix infinite recursion during collection if a ``pytest_ignore_collect`` hook returns ``False`` instead of ``None``. - `3774 <https://github.com/pytest-dev/pytest/issues/3774>`_: Fix bug where decorated fixtures would lose functionality (for example ``mock.patch``). - `3775 <https://github.com/pytest-dev/pytest/issues/3775>`_: Fix bug where importing modules or other objects with prefix ``pytest_`` prefix would raise a ``PluginValidationError``. - `3788 <https://github.com/pytest-dev/pytest/issues/3788>`_: Fix ``AttributeError`` during teardown of ``TestCase`` subclasses which raise an exception during ``__init__``. - `3804 <https://github.com/pytest-dev/pytest/issues/3804>`_: Fix traceback reporting for exceptions with ``__cause__`` cycles. Improved Documentation ---------------------- - `3746 <https://github.com/pytest-dev/pytest/issues/3746>`_: Add documentation for ``metafunc.config`` that had been mistakenly hidden. ``` ### 3.7.1 ``` ========================= Bug Fixes --------- - `3473 <https://github.com/pytest-dev/pytest/issues/3473>`_: Raise immediately if ``approx()`` is given an expected value of a type it doesn't understand (e.g. strings, nested dicts, etc.). - `3712 <https://github.com/pytest-dev/pytest/issues/3712>`_: Correctly represent the dimensions of an numpy array when calling ``repr()`` on ``approx()``. - `3742 <https://github.com/pytest-dev/pytest/issues/3742>`_: Fix incompatibility with third party plugins during collection, which produced the error ``object has no attribute '_collectfile'``. - `3745 <https://github.com/pytest-dev/pytest/issues/3745>`_: Display the absolute path if ``cache_dir`` is not relative to the ``rootdir`` instead of failing. - `3747 <https://github.com/pytest-dev/pytest/issues/3747>`_: Fix compatibility problem with plugins and the warning code issued by fixture functions when they are called directly. - `3748 <https://github.com/pytest-dev/pytest/issues/3748>`_: Fix infinite recursion in ``pytest.approx`` with arrays in ``numpy<1.13``. - `3757 <https://github.com/pytest-dev/pytest/issues/3757>`_: Pin pathlib2 to ``>=2.2.0`` as we require ``__fspath__`` support. - `3763 <https://github.com/pytest-dev/pytest/issues/3763>`_: Fix ``TypeError`` when the assertion message is ``bytes`` in python 3. ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pytest - Changelog: https://pyup.io/changelogs/pytest/ - Homepage: https://docs.pytest.org/en/latest/ </details> ### Update [prospector[with_everything]](https://pypi.org/project/prospector) from **1.1.1** to **1.1.2**. *The bot wasn't able to find a changelog for this release. [Got an idea?](https://github.com/pyupio/changelogs/issues/new)* <details> <summary>Links</summary> - PyPI: https://pypi.org/project/prospector - Docs: http://prospector.readthedocs.io </details>

pombredanne mentioned this issue May 25, 2018

Unlimited recursion on Windows with Python 2.7 untitaker/python-atomicwrites#30

Closed

pytestbot added the type: infrastructure improvement to development/releases/CI structure label May 25, 2018

pytestbot added the type: bug problem that needs to be addressed label May 25, 2018

pombredanne added a commit to aboutcode-org/license-expression that referenced this issue May 25, 2018

Downgrade pytest to 3.5.1

8b0a8a4

work around bug pytest-dev/pytest#3506 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

pombredanne added a commit to aboutcode-org/license-expression that referenced this issue May 25, 2018

Really downgrade pytest to 3.5.1

a91c59d

work around bug pytest-dev/pytest#3506 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

nicoddemus added topic: rewrite related to the assertion rewrite mechanism and removed type: infrastructure improvement to development/releases/CI structure labels May 25, 2018

nicoddemus added a commit to nicoddemus/pyramid-cookiecutter-starter that referenced this issue Aug 27, 2018

Testin pytest recursion error fix - DO NOT MERGE

b77fca7

This commit is testing to ensure the fix for issue pytest-dev/pytest#3506 actually works.

nicoddemus mentioned this issue Aug 27, 2018

Testing pytest recursion error fix - DO NOT MERGE Pylons/pyramid-cookiecutter-starter#56

Closed

nicoddemus mentioned this issue Aug 28, 2018

Avoid possible infinite recursion when writing pyc files in assert rewrite #3895

Merged

nicoddemus closed this as completed in #3895 Aug 28, 2018

stevepiercy mentioned this issue Nov 18, 2018

Drop py2 Pylons/pyramid-cookiecutter-starter#62

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RuntimeError: maximum recursion depth exceeded .... on Windows and Python 2.7 #3506

RuntimeError: maximum recursion depth exceeded .... on Windows and Python 2.7 #3506

pombredanne commented May 25, 2018

pytestbot commented May 25, 2018

nicoddemus commented May 25, 2018

nicoddemus commented May 25, 2018

pombredanne commented May 25, 2018

nicoddemus commented May 25, 2018

pombredanne commented May 27, 2018

stevepiercy commented Aug 27, 2018

nicoddemus commented Aug 27, 2018

RuntimeError: maximum recursion depth exceeded .... on Windows and Python 2.7 #3506

RuntimeError: maximum recursion depth exceeded .... on Windows and Python 2.7 #3506

Comments

pombredanne commented May 25, 2018

pytestbot commented May 25, 2018

nicoddemus commented May 25, 2018

nicoddemus commented May 25, 2018

pombredanne commented May 25, 2018

nicoddemus commented May 25, 2018

pombredanne commented May 27, 2018

stevepiercy commented Aug 27, 2018

nicoddemus commented Aug 27, 2018