Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: report exceptions in threads as errors #56

Closed
pytestbot opened this issue Jun 24, 2011 · 6 comments
Closed

Feature: report exceptions in threads as errors #56

pytestbot opened this issue Jun 24, 2011 · 6 comments
Labels
type: enhancement new feature or API change, should be merged into features branch
Milestone
3.0

Comments

@pytestbot
Copy link
Contributor

Originally reported by: Maciej Fijalkowski (BitBucket: fijal, GitHub: fijal)

Trial has a cool feature, where exceptions that happen in other threads are reported as errors. This is especially interesting in case of py.test which captures the stdout, so it's easy to miss (especially during thread finish).
@pytestbot
Copy link
Contributor Author

Original comment by Floris Bruynooghe (BitBucket: flub, GitHub: flub):

This would also be very cool for greenlets, though I am not sure if it's possible.

@pytestbot
Copy link
Contributor Author

Original comment by holger krekel (BitBucket: hpk42, GitHub: hpk42):

pyest has no notion of things running in threads or greenlets. How do you suppose it could work that pytest notices such exceptions?

@pytestbot
Copy link
Contributor Author

Original comment by Maciej Fijalkowski (BitBucket: fijal, GitHub: fijal):

There is sys.excepthook and here is some discussion:

http://bugs.python.org/issue1230540

I didn't check what trial does :)

@pytestbot
Copy link
Contributor Author

Original comment by holger krekel (BitBucket: hpk42, GitHub: hpk42):

Don't have the time to look or think deeper about this issue at the moment. If you have a concrete suggestion i'd be interested.

@pytestbot pytestbot added the type: enhancement new feature or API change, should be merged into features branch label Jun 15, 2015
@RonnyPfannschmidt
Copy link
Member

relates to #73

@RonnyPfannschmidt RonnyPfannschmidt added this to the 3.0 milestone Sep 13, 2015
@RonnyPfannschmidt
Copy link
Member

Closing this one as it is really hard to do sanely in the general case
More specific variants make sense for framework plugins with more awareness

@RonnyPfannschmidt RonnyPfannschmidt mentioned this issue Dec 30, 2015
Closed
@pytestbot pytestbot mentioned this issue Jun 27, 2018
Open
fkohlgrueber pushed a commit to fkohlgrueber/pytest that referenced this issue Oct 27, 2018
@ambv
Support sticky standalone comments (comments preceding defs, classes,…
52fda8b 
… and decorators)

Fixes pytest-dev#56
Fixes pytest-dev#154
mgorny pushed a commit to mgorny/pytest that referenced this issue May 27, 2023
@eeaston
Merge pull request pytest-dev#56 from xoviat/common_setup
586ab63 
allow installation from source using pip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement new feature or API change, should be merged into features branch
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
3 participants
@RonnyPfannschmidt @pfctdayelise @pytestbot