-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
junitxml make verbose output opt-in #595
Comments
@RonnyPfannschmidt I would like to help here |
@Akasurde we'd gladly accept a PR the current idea to solve this would be to implement a CLI flag and only add the output sections if it is true To ensure backward compatibility, we should probably default to true and have the CLI option set the flag to false using store_false |
Hi @RonnyPfannschmidt, can I take this issue? It would be probably nice start into py-test codebase. |
@jotes feel free to, its been waiting since months |
@jotes did you find any time for this one, it would be a nice perk for 3.0 |
@RonnyPfannschmidt Hi, I'm planning to dig into it during the weekend. If it's more urgent, please feel free to assign someone else. |
its not "urgent" per se its just that if nobody volunteers it before 3.0 it will have to go to a later feature release |
@RonnyPfannschmidt Okay, i'll ping you as soon as I have something to review. |
As #2091 shows, skipped tests no longer add I say we close this issue as "fixed" and don't bother with a new flag to restore the previous behavior because so far nobody complained. Also it seems to me the original behavior was an accident rather than intentional. |
Originally reported by: David Szotten (BitBucket: davidszotten, GitHub: davidszotten)
6954363 changed junitxml to include captured output for passing and skipped tests in the output by default. this makes the xml unnecessarily large for our use cases
i think this behaviour should become opt-in (or at the very least add opt-out)
feature is easy to add, but my issue was with giving this a good option name. i was also slightly concerned with growing the already large list of options with parameters that only apply when already using --junitxml
are there any plans for grouping/namespacing options (so that a top level --help would be less verbose)
and setting aside the digression, any thoughts on making this opt-in (and if so, of a good option name. so far considered junitxml-verbose-output, junitxml-always-include-output; just using the --verbose flag (don't like that))
thanks
The text was updated successfully, but these errors were encountered: