-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fall back to native when handeling to exception groups #10071
Conversation
d95ddd9
to
5e729b8
Compare
4ec664d
to
d38da9d
Compare
642fff8
to
be502f9
Compare
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while this addresses #9159 its not a solution (which would be support in ExceptionInfo)
the amount of work to do that is unclear
please note that im happy to merge this one as a first step towards full support, but the change note should clarify that it enforces native instead of supporting them also the issue has to remain open until a pytest-native implementation is/was done |
Agree on that. I am happy to help with the pytest-native implementation but I got the idea that it may be a lot of work and I can change this PR as a temporary workaround rather than a full fix to the issue. |
Showing inner exceptions in
ExceptionGroups
when using display options other than--tb=native
.Currently, the solution is it falls back on using a native display to show the inner exceptions but is happy to do a more custom display if needed.
see #9159