Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regendoc #10252

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Fix regendoc #10252

merged 1 commit into from
Aug 31, 2022

Conversation

nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Aug 26, 2022

The finalizers example was wiping out code needed for the examples below.

Noticed this in #10250

Closes #10252

@nicoddemus
Copy link
Member Author

Gentle ping anyone?

Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, did you run regendoc on to be safe?

The finalizers example was wiping out code needed for the examples below.
@nicoddemus
Copy link
Member Author

Yes, just double checked, and while at it I applied the fixes from #10257 too. 👍

@nicoddemus nicoddemus merged commit a9bbfb8 into pytest-dev:main Aug 31, 2022
@nicoddemus nicoddemus deleted the fix-regendoc branch August 31, 2022 17:32
@github-actions github-actions bot mentioned this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants