-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement #12231 new flag --xfail-tb #12262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @okken for tackling this so quickly!
As you mention indeed we still need tests and docs for this, but also I would like to see some other specific tests:
- a normal failure and an xfail failure, with
tb=line
andxfail-tb=auto
, and check the output. - I suppose just changing
--xfail-tb
default tono
will require update some test(s), but if not, we need to check that the default does not produce any xfail tracebacks.
I've written a rather verbose changelog entry. Feel free to shorten, tighten, completely rewrite, make suggestions, etc. |
@nicoddemus I think I've done all necessary changes |
I didn't quite do the tests as requested. by "a normal failure and an xfail failure, with tb=line and xfail-tb=auto, and check the output."
Right now I've got a -rx test, an -rx --xfail-tb=short, and an -rx --xfail-tb=line test. I think that's sufficient. |
Converting to draft, because I'm still working on it, and thinking about behavior. see #12231 for discussion and questions |
…into okken_12231_xfail_tb
for more information, see https://pre-commit.ci
Accidentally deleted my fork, along with this branch. |
This implements issue #12231, making xfail tracebacks optional.
Introduces a new flag --xfail-tb, that acts just like --tb, but just for xfail tracebacks.
With this feature in place, turning off xfail tracebacks is as simple as
--xfail-tb=no
, and even works when-rx
or-ra
are present.This is a first pass at the PR.
Still todo: