-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a "strict" parameter to xfail #1386
Conversation
well done, i wish GH had a merge on pass button |
Thanks! @rabbbit could you review as well, and perhaps even try it? Would hate for this to be merged only to discover after the release it still does not fit your needs and others. |
Does github have any badge options I could give you? :) 👍 Yeah, it looks awesome. I wouldn't bother with the bool-parsing, and I have troubles understanding actual code, but functionality wise it looks perfect. |
Add a "strict" parameter to xfail
we should consider re-priming the xfail result to also handle setup/teardown xfails instead of just doing a fail on exit i wonder if xpass in strict mode should always report to the terminal :) |
Missed the CHANGELOG, I will just push it directly to master |
Thanks for merging it!
What do you mean by "re-priming"?
The current implementation fails the test entirely... or do you mean something else? |
what i meant is that a) instead of running fail in the pyfunc_call, we should let a normal xfail propagate |
@@ -178,6 +184,18 @@ def pytest_runtest_setup(item): | |||
|
|||
def pytest_pyfunc_call(pyfuncitem): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realized this is the wrong hook for this. 😦
It is not executing the test at all when strict
is True... I will fix this later tonight. 😞
addini
skipping.rst
while adding the new docs, I think it is easier to use it as a reference while staying true to its original "tutorial" intent (a crude rendering can be seen here).strict
parameter fromFalse
toTrue
. Not sure if we want to do that or not.Fix #1355