-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise CollectError if import test module fails #1520
Raise CollectError if import test module fails #1520
Conversation
Thanks! While I agree that this seems like the original user report was a stretch, I don't think it hurts either. 😁 |
I improved the error message a little, fixed failing tests and added a CHANGELOG entry. I force pushed the branch instead of adding commits to avoid cluttering the repository. |
Thanks! The tests are failing because of a minor output detail between Python versions, could you please fix it? |
Yep I'm on it. |
One of the reasons for failing to import the test module is invalid Python identifiers in the full package path of the test module. fix #1426
Oh sorry @omarkohl, just now I saw that you did make a new commit. Thanks again! |
A few tests are still failing and need to be fixed. I will do that and adapt the
CHANGELOG
if the change makes sense.I honestly don't see much point in fixing #1426 (but did it because it looked simple enough).
Here's a quick checklist that should be present in PRs:
master
; for new features, targetfeatures
AUTHORS
CHANGELOG
(choose any open position to avoid merge conflicts with other PRs)One of the reasons for failing to import the test module is invalid Python
identifiers in the full package path of the test module.
fix #1426