fixes #1210 adds stderr write for pytest.exit(msg) call #1655
Conversation
|
Thanks! Could you please take a look at the failing test? I also think this should go to the |
| excinfo = _pytest._code.ExceptionInfo() | ||
| config.hook.pytest_keyboard_interrupt(excinfo=excinfo) | ||
| session.exitstatus = EXIT_INTERRUPTED | ||
| except pytest.Exit as e: | ||
| sys.stderr.write('{0}: {1}\n'.format(type(e).__name__, e.msg)) |
There was a problem hiding this comment.
What is the session.exitstatus when pytest.Exit is caught? It looks like it might be 0 and before this change it was EXIT_INTERNALERROR. But I might be wrong... maybe check it in the test?
There was a problem hiding this comment.
Good point, I will have the test verify this.
|
Thanks @JonathonSonesen! 😁 Closing this for now, as it should target |
|
Yeah no problem i will get this fixed up! |
| @@ -90,10 +90,12 @@ def wrap_session(config, doit): | |||
| session.exitstatus = doit(config, session) or 0 | |||
| except pytest.UsageError: | |||
| raise | |||
| except KeyboardInterrupt: | |||
| except KeyboardInterrupt as e: | |||
| excinfo = _pytest._code.ExceptionInfo() | |||
There was a problem hiding this comment.
Few points:
- there's no need for
as ebecause the exception data is already inexcinfo - I'm unsure if this is the right place to do the outputting
- I tested
pytest.exiting from a test, and it now prints the msg twice - I think investigating this and why it doesn't print whenpytest.exiting frompytest_configurewill point to the right place to do the outputting - also when the tests ran, I saw quite a few errors - these will also help point to a good solution
There was a problem hiding this comment.
Yes thanks for bringing this up again, I think it may have to do with the init_state logic that we were talking about prior to your departure.
I will do more work on this for sure.
There was a problem hiding this comment.
@JonathonSonesen cool! Ping me a message if you wanna discuss it.
This PR addresses issue #1210 writing the exception message to stderr as well as the class name of the exception.