Highlight the path of file location in error report

[suzaku]

Make it more obvious when we need to copy the file path.

[coveralls]

Coverage increased (+0.0009%) to 92.317% when pulling 4c53909 on suzaku:highlight-file-loc into ffb583a on pytest-dev:master.

[nicoddemus]

Thanks for the PR! 😄

Here's what it looks like:

This looks good to me, if nobody else has any comments I will merge this tomorrow. 👍

[The-Compiler]

Thanks for the screenshot @nicoddemus! Shouldn't this go to features though?

[nicoddemus]

Good point, I could rebase it tomorrow before merging though.

Weird that the freeze test env is failing on Windows, it was passing just a few days ago:

freeze runtests: commands[1] | C:\projects\pytest\.tox\freeze\Scripts\python tox_run.py
Traceback (most recent call last):
  File "site-packages\PyInstaller\loader\rthooks\pyi_rth_pkgres.py", line 11, in <module>
  File "<frozen importlib._bootstrap>", line 969, in _find_and_load
  File "<frozen importlib._bootstrap>", line 958, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 664, in _load_unlocked
  File "<frozen importlib._bootstrap>", line 634, in _load_backward_compatible
  File "c:\projects\pytest\.tox\freeze\lib\site-packages\PyInstaller\loader\pyimod03_importers.py", line 389, in load_module
    exec(bytecode, module.__dict__)
  File "site-packages\pkg_resources\__init__.py", line 2958, in <module>
  File "site-packages\pkg_resources\__init__.py", line 2944, in _call_aside
  File "site-packages\pkg_resources\__init__.py", line 2986, in _initialize_master_working_set
UnboundLocalError: local variable 'dist' referenced before assignment
Failed to execute script pyi_rth_pkgres
ERROR: InvocationError: 'C:\\projects\\pytest\\.tox\\freeze\\Scripts\\python tox_run.py'

Seems to be related to executing the pyi_rth_pkgres internal module from PyInstaller. Perhaps @codewarrior0 or @htgoebel have any hints at what might be the problem?

[The-Compiler]

That's a setuptools bug, see pypa/setuptools#702 - pypa/setuptools#703 was now merged, and seeing how often setuptools is released I bet there will be a new release very soon.

[nicoddemus]

Great, thanks for looking it up! 😁

[suzaku]

Thanks for replying. Let me know if there's anything I can do to fix the failing build.

[nicoddemus]

@suzaku just a question, why did you changed those tests? Your change to the terminal writer required those to be changed?

[suzaku]

@nicoddemus Yes, otherwise the tests would fail. After I used write to print out the highlighted file path, the tests complained that there's no write method on the TWMock object. So I added a write method for TWMock and the corresponding way to check writes.

I think there must be a better way to do this, maybe I can refactor these tests and eliminate replace TWMock with a mock.Mock later in another pull request?

[nicoddemus]

Closing in favor of #1781. Thanks again @suzaku!

[suzaku]

:)