Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code which guesses parametrized scope based on arguments #1847

Merged
merged 1 commit into from
Aug 23, 2016
Merged

Fix code which guesses parametrized scope based on arguments #1847

merged 1 commit into from
Aug 23, 2016
+153 −46

Conversation

nicoddemus
Copy link
Member

Many thanks to @Kingdread for providing the initial solution; I just added a few more tests and refactored the code a little bit.

Fix #1832

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 93.03% when pulling 53a0e2b on nicoddemus:parametrize-session-scopes into d99ceb1 on pytest-dev:master.

@nicoddemus nicoddemus mentioned this pull request Aug 23, 2016
Closed
@RonnyPfannschmidt RonnyPfannschmidt merged commit 7538680 into pytest-dev:master Aug 23, 2016
@nicoddemus nicoddemus deleted the parametrize-session-scopes branch August 23, 2016 16:07
@The-Compiler
Copy link
Member

I can confirm the fix works - thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicoddemus @coveralls @The-Compiler @RonnyPfannschmidt