Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs warnings as errors and initial page similar to README #1848

Merged
merged 1 commit into from
Aug 26, 2016

Conversation

nicoddemus
Copy link
Member

I pushed this branch to pytest's repository instead of mine so readthedocs would build the documentation, which can be browsed here.

Fixes #432, Fixes #1112, Fixes #1708, Fixes #1829

@@ -711,31 +711,26 @@ class Metafunc(fixtures.FuncargnamesCompatAttr):
They help to inspect a test function and to generate tests according to
test configuration or values specified in the class or module where a
test function is defined.

:ivar fixturenames: set of fixture names required by the test function
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to change from docstring to inline comments because of sphinx-doc/sphinx#2549. 😞

@nicoddemus
Copy link
Member Author

After fixing the numerous errors in the documentation (missing links, syntax errors, etc) it's clear to me that treating documentation warnings as errors is absolutely vital to keep the documentation healthy. 😅

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.025% when pulling d359916 on doc-warnings into d99ceb1 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.025% when pulling 8717a6e on doc-warnings into d99ceb1 on master.

@@ -39,8 +39,6 @@ Over 20 participants took part from 4 continents, including employees
from Splunk, Personalkollen, Cobe.io, FanDuel and Dolby. Some newcomers
mixed with developers who have worked on pytest since its beginning, and
of course everyone in between.
Ana Ribeiro, Brazil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where did we go ^^

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was decided to remove the entire participants list at some point, but those two names seem to be have left by accident (they were a syntax error in Sphinx)

@nicoddemus
Copy link
Member Author

Perhaps @hackebrot and @pfctdayelise would like to take a look as well? 😁


To check your installation has installed the correct version::

$ pytest --version
This is pytest version 3.0.0, imported from $PYTHON_PREFIX/lib/python3.5/site-packages/pytest.py

If you get an error checkout :ref:`installation issues`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this refer to an existing document? If so, that reference seems useful to me?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't... I didn't really track where it might have went, but I remember there being something related to weird Windows installation problems because "python" wasn't on the PATH... don't think it is really relevant if that's what it was.

@nicoddemus nicoddemus force-pushed the doc-warnings branch 2 times, most recently from f01ebb2 to 94270a0 Compare August 23, 2016 21:34
@nicoddemus
Copy link
Member Author

Pushed last comments made by @The-Compiler.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.03% when pulling 94270a0 on doc-warnings into 7538680 on master.

@hackebrot
Copy link
Member

Hey! 👋

I'd love to review this, but I don't have the time today. 😞

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.03% when pulling 94270a0 on doc-warnings into 7538680 on master.

@@ -26,6 +26,7 @@ env:
- TESTENV=py27-nobyte
- TESTENV=doctesting
- TESTENV=freeze
- TESTENV=docs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

* Changed "index" to be more similar to the README (#1708).
* Fixes numerous issues like missing documents, syntax errors, etc (#1829, #432).
* Mention all docs in "contents.rst" so it's easier for users to locate (#1112).
* Add doc generation and checking to Travis and AppVeyor, to avoid re-introducing errors.

Fixes #432, Fixes #1112, Fixes #1708, Fixes #1829
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.027% when pulling 519f02b on doc-warnings into cb7c472 on master.

@hackebrot
Copy link
Member

Great work @nicoddemus! 👏

@hackebrot hackebrot merged commit e75078e into master Aug 26, 2016
@nicoddemus nicoddemus deleted the doc-warnings branch August 26, 2016 22:03
@hackebrot hackebrot added the type: docs documentation improvement, missing or needing clarification label Jul 15, 2017
@blueyed blueyed mentioned this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: docs documentation improvement, missing or needing clarification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants