Release 3.0.2 #1896
Merged
Release 3.0.2 #1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * matthiasha | ||
|
|
||
| Happy testing, | ||
| The pytest Development Team |
| @@ -88,7 +88,7 @@ def setup(self): | |||
| if self.dtest is not None: | |||
| self.fixture_request = _setup_fixtures(self) | |||
| globs = dict(getfixture=self.fixture_request.getfixturevalue) | |||
| for name, value in self.fixture_request.getfuncargvalue('doctest_namespace').items(): | |||
| for name, value in self.fixture_request.getfixturevalue('doctest_namespace').items(): | |||
There was a problem hiding this comment.
I added the fix for #1898 in this PR because it was trivial and I didn't want to open a separate PR just for that, hope that's OK.
|
Anything else guys? I was thinking of pushing the release to PyPI later tonight, unless somebody wants more time to review this more carefully. |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds: