Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report teardown output on test failure #2030

Merged
merged 1 commit into from
Oct 31, 2016
Merged

Conversation

matclab
Copy link

@matclab matclab commented Oct 30, 2016

Until now, teardown stdout/stderr output was not reported upon test failure.
However such output is sometime necessary to understand the failure.

fix #442

Until now, teardown stdout/stderr output was not reported upon test failure.
However such output is sometime necessary to understand the failure.

fix pytest-dev#442
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6f93ffb on matclab:fix/442 into * on pytest-dev:master*.

@RonnyPfannschmidt
Copy link
Member

at first glance this looks good, well done 👍

before merging i'd like to take a look at the actual output as well

also i wonder if this should go to features - and would like to hear the opinion of the other maintainers

@matclab
Copy link
Author

matclab commented Oct 30, 2016

I have no strong advice about the feature/fix status.
However, seeing the setup output when the test failed, I was quite
surprised to not see the teardonw output (In fact I have suspected a bug in
my god for long before looking for a bug report in pytest)..

On Sun, Oct 30, 2016 at 10:34 AM Ronny Pfannschmidt <
notifications@github.com> wrote:

at first glance this looks good, well done 👍

before merging i'd like to take a look at the actual output as well

also i wonder if this should go to features - and would like to hear the
opinion of the other maintainers


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2030 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA8LNuGgUqgr4CXDiTjydMCd2ulZJR73ks5q5GSOgaJpZM4KkU2u
.

@nicoddemus nicoddemus merged commit e354455 into pytest-dev:master Oct 31, 2016
@nicoddemus
Copy link
Member

@matclab thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make reported captured output include function scope fixture finalizer output.
4 participants