Allow problematic jobs to fail instead of commenting them out #2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
force-pushed
the
error-matrix-for-failing-jobs
branch
from
94bde83
to
98caeed
Compare
|
whops - i hate that the ci's cancel if im too quick to merge |
|
Did it work on appveyor? |
|
Hah, pypy's problem on Windows solved itself. 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of commenting out jobs, allow them to fail in CI.
This seems like a better strategy because at least they will appear in the job list, as a constant reminder for us to take a look or even better, start to get green again because of an upstream change.
Related to #1989 and #1963