Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flake8 E305 and E306 errors #2071

Merged
merged 2 commits into from
Nov 22, 2016

Conversation

nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Nov 20, 2016

These errors started to appear with flake8-3.1.1, while they don't appear with version 3.1.0 (weird).

This PR contains only white-space changes.

EDIT: also added a line to tox.ini for flake8 to ignore pluggy.py.

These errors started to appear with flake8-3.1.1, while they don't appear with
version 3.1.0 (weird).
@nicoddemus
Copy link
Member Author

Disclaimer: just committed a fix to test_excinfo_getstatement because it depended on the line numbers and that changed in the first commit.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.79% when pulling 984d4ce on nicoddemus:fix-flake8 into cbf261c on pytest-dev:master.

@nicoddemus
Copy link
Member Author

It would be nice if someone could take a look at this ASAP, all PRs are currently broken because of this. 😞

@RonnyPfannschmidt
Copy link
Member

i8t pretty much looks like they fixed a bug or added a new error number, im inclined to think we should either add the number or get rid of all exclusion and be done wit it once and for all

@RonnyPfannschmidt RonnyPfannschmidt merged commit a3319ff into pytest-dev:master Nov 22, 2016
@nicoddemus nicoddemus deleted the fix-flake8 branch November 22, 2016 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants