Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support code for earlier Python 3 version in Source.compile #2106

Merged
merged 2 commits into from
Dec 1, 2016
Merged

Remove support code for earlier Python 3 version in Source.compile #2106

merged 2 commits into from
Dec 1, 2016

Conversation

nicoddemus
Copy link
Member

This code leaves None in sys.modules as a side effect but is no longer needed in the Python 3 versions we support, it seems.

Fix #2103

@nicoddemus
Remove support code for earlier Python 3 version in Source.compile
f8d1952 
This code leaves None in sys.modules as a side effect but is no longer needed in the Python 3 versions we support.

Fix pytest-dev#2103
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 92.823% when pulling f8d1952 on nicoddemus:sys-modules-none into 8208a77 on pytest-dev:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 92.823% when pulling 30f0152 on nicoddemus:sys-modules-none into 8208a77 on pytest-dev:master.

@RonnyPfannschmidt RonnyPfannschmidt merged commit e612619 into pytest-dev:master Dec 1, 2016
@nicoddemus nicoddemus mentioned this pull request Dec 1, 2016
Merged
@nicoddemus nicoddemus deleted the sys-modules-none branch December 28, 2016 01:12
@QuLogic QuLogic mentioned this pull request Jul 10, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicoddemus @coveralls @RonnyPfannschmidt