'xfail' markers without a condition no longer rely on the underlying Item objects deriving from PyobjMixin

[barneygale]

_getglobals() assumes that self.item has a obj attribute. This is normally provided by PyobjMixin, but it doesn't seem necessary if there's no condition to evaluate. Therefore this patch calls _getglobals() a little later on when it's actually needed for condition evaluation.

[coveralls]

Coverage remained the same at 92.832% when pulling 99e3a6d on barneygale:xfail_without_condition_getglobals into da40bcf on pytest-dev:master.

[nicoddemus]

@barneygale thanks for the PR.

linting and docs environments broke because you didn't add a link to your user name to the CHANGELOG. See the others for an example and please make sure to add your user name in alphabetical order.

Also, please rebase on the latest master.

[barneygale]

Rebased and (hopefully) fixed the changelog.

[coveralls]

Coverage remained the same at 92.816% when pulling df409a0 on barneygale:xfail_without_condition_getglobals into 78f0388 on pytest-dev:master.

[coveralls]

Coverage remained the same at 92.816% when pulling df409a0 on barneygale:xfail_without_condition_getglobals into 78f0388 on pytest-dev:master.

[nicoddemus]

Hmm just realized this: should we add a test for this? Otherwise we risk re-introducing this requirement in the future by mistake.

[barneygale]

Yep, I'll look into it

[nicoddemus]

Thanks! 👍