Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readouterr_bytes for retrieving captured binary output #2279

Closed
wants to merge 1 commit into from
Closed

Add readouterr_bytes for retrieving captured binary output #2279

wants to merge 1 commit into from

Conversation

asottile
Copy link
Member

Followup to #2266 and #1407 to enable assertions on arbitrary binary output

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 92.744% when pulling 97bf365 on asottile:readouterr_bytes into 0f3d7ac on pytest-dev:features.

@asottile
Copy link
Member Author

Oh hmm, I forgot to test in python2. I'll have to think about this some more...

@RonnyPfannschmidt
Copy link
Member

@asottile this is to the point wrt my comments to the last pr, instead of having capture configured for binary, we now get different sets of targeted methods with strange errors,

even if we add those please mark them as provisional, i'm reasonably certain a better capture model makes this mess unnecessary

@asottile
Copy link
Member Author

asottile commented Mar 1, 2017

I'll reopen this once I've reworked python2 support (when I have time!)

@asottile asottile closed this Mar 1, 2017
@asottile asottile mentioned this pull request Nov 14, 2017
@asottile asottile deleted the readouterr_bytes branch August 26, 2018 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants